Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change <br> to <br/> #3879

Closed
wants to merge 1 commit into from
Closed

Conversation

patrickhlauke
Copy link
Member

Due to the XML-based publication pipeline, need to have self-closing <br/>. Otherwise when trying to build locally at least, ant chokes.

Due to the XML-based publication pipeline, need to have self-closing `<br/>`. Otherwise when trying to build locally at least, `ant` chokes.
Copy link
Member

@scottaohara scottaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took a look and approving per the rational as to why this needs to happen. but otherwise, boo :)

Copy link
Contributor

@bruce-usab bruce-usab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Understanding Target Size Enhanced uses something semantic rather than BR ?

@fstrr
Copy link
Contributor

fstrr commented Jun 7, 2024

Seems like a prime candidate for a description list.

@patrickhlauke
Copy link
Member Author

can/should we do that in a separate PR, rather than this very targeted (pun) PR to just fix some xml?

@bruce-usab
Copy link
Contributor

From call 6/7, concur with just making this bug fix.

@fstrr
Copy link
Contributor

fstrr commented Jun 7, 2024

'Tis done - #3901

@patrickhlauke
Copy link
Member Author

as @iadawn 's #3899 already fixes the first change for the target size understanding (likely he bumped into the same issue i saw when trying to build the spec/understanding), and the other instances of naked <br> do not need to be fixed as they don't go through the XML pipeline...closing this as superseded

@patrickhlauke patrickhlauke deleted the patrickhlauke-chore-xml-validity branch June 7, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants