-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change <br> to <br/> #3879
Change <br> to <br/> #3879
Conversation
Due to the XML-based publication pipeline, need to have self-closing `<br/>`. Otherwise when trying to build locally at least, `ant` chokes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
took a look and approving per the rational as to why this needs to happen. but otherwise, boo :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should Understanding Target Size Enhanced uses something semantic rather than BR ?
Seems like a prime candidate for a description list. |
can/should we do that in a separate PR, rather than this very targeted (pun) PR to just fix some xml? |
From call 6/7, concur with just making this bug fix. |
'Tis done - #3901 |
as @iadawn 's #3899 already fixes the first change for the target size understanding (likely he bumped into the same issue i saw when trying to build the spec/understanding), and the other instances of naked |
Due to the XML-based publication pipeline, need to have self-closing
<br/>
. Otherwise when trying to build locally at least,ant
chokes.