New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we ignore NDEFMessage.serialNumber for NFCWriter::push()? #224
Comments
Yes, you cannot write the serialnumber. |
NDEFMessage should be renamed NFCMessage. Maybe it is possible to do
|
Two types of message may make it confusing for developers. As the |serialNumber| is only meaningful to NFCReadingEvent, how about move the this attribute to this event, making the NDEFMessage more clean. dictionary NDEFMessage { I think |serialNumber| maybe don't need to be nullable because string can be empty. |
The UID is not part of NDEF messages, so I would support moving out the tag specific (low-level) information from NDEF message structure. Anyway, at the moment the above proposal looks good to me. |
Move serialNumber from NDEFMessage to NFCReadingEvent, fixes #224
An attribute |serialNumber| has been added to NDEFMessage dictionary, and it seems only meaningful to NFCReadingEvent.
According to the the push method in Spec, |serialNumber| in NDEFMessage passed to NFCWriter::push() will be ignored. Should we make a clear statement about this?
The text was updated successfully, but these errors were encountered: