Move serialNumber from NDEFMessage to NFCReadingEvent, fixes #224 #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zolkis would you please take a look at this? |
|
Looks good. |
kenchris
approved these changes
Jun 12, 2019
|
Thank you all! The CL adding ReadingEvent will be updated accordingly soon . |
xiuqijix
added a commit
to xiuqijix/web-platform-tests
that referenced
this pull request
Jun 14, 2019
Spec change in #w3c/web-nfc/pull/227 - Move "serialNumber" from "NDEFMessage" to "NFCReadingEvent"/"NFCReadingEventInit"
Honry
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 14, 2019
* Adapt to web-nfc latest spec Spec change in #w3c/web-nfc/pull/227 - Move "serialNumber" from "NDEFMessage" to "NFCReadingEvent"/"NFCReadingEventInit"
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 20, 2019
This CL introduces IDLs for NFCReadingEvent and NFCReadingEventInit interfaces, and updates the baseline of relevant wpt tests. http://w3c.github.io/web-nfc/#dom-nfcreadingevent The corresponding spec changes were introduced in w3c/web-nfc#179 w3c/web-nfc#227 BUG=520391 Change-Id: If2090d73ce746208a9e535fe31b6d52a9940d2fe
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 2, 2019
This CL introduces IDLs for NFCReadingEvent and NFCReadingEventInit interfaces, and updates the baseline of relevant wpt tests. http://w3c.github.io/web-nfc/#dom-nfcreadingevent The corresponding spec changes were introduced in w3c/web-nfc#179 w3c/web-nfc#227 BUG=520391 Change-Id: If2090d73ce746208a9e535fe31b6d52a9940d2fe
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 4, 2019
This CL introduces IDLs for NFCReadingEvent and NFCReadingEventInit interfaces, and updates the baseline of relevant wpt tests. http://w3c.github.io/web-nfc/#dom-nfcreadingevent The corresponding spec changes were introduced in w3c/web-nfc#179 w3c/web-nfc#227 BUG=520391 Change-Id: If2090d73ce746208a9e535fe31b6d52a9940d2fe
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 10, 2019
This CL introduces IDLs for NFCReadingEvent and NFCReadingEventInit interfaces, and updates the baseline of relevant wpt tests. http://w3c.github.io/web-nfc/#dom-nfcreadingevent The corresponding spec changes were introduced in w3c/web-nfc#179 w3c/web-nfc#227 BUG=520391 Change-Id: If2090d73ce746208a9e535fe31b6d52a9940d2fe
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 17, 2019
This CL introduces IDLs for NFCReadingEvent and NFCReadingEventInit interfaces, and updates the baseline of relevant wpt tests. http://w3c.github.io/web-nfc/#dom-nfcreadingevent The corresponding spec changes were introduced in w3c/web-nfc#179 w3c/web-nfc#227 BUG=520391 Change-Id: If2090d73ce746208a9e535fe31b6d52a9940d2fe
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 23, 2019
* Adapt to web-nfc latest spec Spec change in #w3c/web-nfc/pull/227 - Move "serialNumber" from "NDEFMessage" to "NFCReadingEvent"/"NFCReadingEventInit"
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 23, 2019
This CL introduces IDLs for NFCReadingEvent and NFCReadingEventInit interfaces, and updates the baseline of relevant wpt tests. http://w3c.github.io/web-nfc/#dom-nfcreadingevent The corresponding spec changes were introduced in w3c/web-nfc#179 w3c/web-nfc#227 BUG=520391 Change-Id: If2090d73ce746208a9e535fe31b6d52a9940d2fe
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 23, 2019
This CL introduces IDLs for NFCReadingEvent and NFCReadingEventInit interfaces, and updates the baseline of relevant wpt tests. http://w3c.github.io/web-nfc/#dom-nfcreadingevent The corresponding spec changes were introduced in w3c/web-nfc#179 w3c/web-nfc#227 BUG=520391 Change-Id: If2090d73ce746208a9e535fe31b6d52a9940d2fe
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jul 23, 2019
This CL introduces IDLs for NFCReadingEvent and NFCReadingEventInit interfaces, and updates the baseline of relevant wpt tests. http://w3c.github.io/web-nfc/#dom-nfcreadingevent The corresponding spec changes were introduced in w3c/web-nfc#179 w3c/web-nfc#227 BUG=520391 Change-Id: If2090d73ce746208a9e535fe31b6d52a9940d2fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655092 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#679910}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 23, 2019
This CL introduces IDLs for NFCReadingEvent and NFCReadingEventInit interfaces, and updates the baseline of relevant wpt tests. http://w3c.github.io/web-nfc/#dom-nfcreadingevent The corresponding spec changes were introduced in w3c/web-nfc#179 w3c/web-nfc#227 BUG=520391 Change-Id: If2090d73ce746208a9e535fe31b6d52a9940d2fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655092 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#679910}
pull bot
pushed a commit
to hoojaoh/web-platform-tests
that referenced
this pull request
Jul 23, 2019
This CL introduces IDLs for NFCReadingEvent and NFCReadingEventInit interfaces, and updates the baseline of relevant wpt tests. http://w3c.github.io/web-nfc/#dom-nfcreadingevent The corresponding spec changes were introduced in w3c/web-nfc#179 w3c/web-nfc#227 BUG=520391 Change-Id: If2090d73ce746208a9e535fe31b6d52a9940d2fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655092 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#679910}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 24, 2019
Automatic update from web-platform-tests Adapt to web-nfc latest spec (#17336) * Adapt to web-nfc latest spec Spec change in #w3c/web-nfc/pull/227 - Move "serialNumber" from "NDEFMessage" to "NFCReadingEvent"/"NFCReadingEventInit" -- wpt-commits: b551484d02846d38e186b25f0c443db76fe5da5c wpt-pr: 17336
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jul 25, 2019
Automatic update from web-platform-tests Adapt to web-nfc latest spec (#17336) * Adapt to web-nfc latest spec Spec change in #w3c/web-nfc/pull/227 - Move "serialNumber" from "NDEFMessage" to "NFCReadingEvent"/"NFCReadingEventInit" -- wpt-commits: b551484d02846d38e186b25f0c443db76fe5da5c wpt-pr: 17336
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jul 25, 2019
This CL implements NFCReader interface and updates the baseline of relevant wpt tests. http://w3c.github.io/web-nfc/#dom-nfcreader The corresponding spec changes were introduced in w3c/web-nfc#179 w3c/web-nfc#227 BUG=520391 Change-Id: I10b92211cea9e95c1af5c30c005666e5752f6991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708292 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#680718}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 31, 2019
…ent and NFCReadingEventInit., a=testonly Automatic update from web-platform-tests [webnfc] Introduce IDLs for NFCReadingEvent and NFCReadingEventInit. This CL introduces IDLs for NFCReadingEvent and NFCReadingEventInit interfaces, and updates the baseline of relevant wpt tests. http://w3c.github.io/web-nfc/#dom-nfcreadingevent The corresponding spec changes were introduced in w3c/web-nfc#179 w3c/web-nfc#227 BUG=520391 Change-Id: If2090d73ce746208a9e535fe31b6d52a9940d2fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655092 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#679910} -- wpt-commits: 239561ebf7630cd4419dc8cea83606f27062bf87 wpt-pr: 17410
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jul 31, 2019
…ent and NFCReadingEventInit., a=testonly Automatic update from web-platform-tests [webnfc] Introduce IDLs for NFCReadingEvent and NFCReadingEventInit. This CL introduces IDLs for NFCReadingEvent and NFCReadingEventInit interfaces, and updates the baseline of relevant wpt tests. http://w3c.github.io/web-nfc/#dom-nfcreadingevent The corresponding spec changes were introduced in w3c/web-nfc#179 w3c/web-nfc#227 BUG=520391 Change-Id: If2090d73ce746208a9e535fe31b6d52a9940d2fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655092 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#679910} -- wpt-commits: 239561ebf7630cd4419dc8cea83606f27062bf87 wpt-pr: 17410
natechapin
pushed a commit
to natechapin/wpt
that referenced
this pull request
Aug 23, 2019
This CL introduces IDLs for NFCReadingEvent and NFCReadingEventInit interfaces, and updates the baseline of relevant wpt tests. http://w3c.github.io/web-nfc/#dom-nfcreadingevent The corresponding spec changes were introduced in w3c/web-nfc#179 w3c/web-nfc#227 BUG=520391 Change-Id: If2090d73ce746208a9e535fe31b6d52a9940d2fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655092 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#679910}
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
Automatic update from web-platform-tests Adapt to web-nfc latest spec (#17336) * Adapt to web-nfc latest spec Spec change in #w3c/web-nfc/pull/227 - Move "serialNumber" from "NDEFMessage" to "NFCReadingEvent"/"NFCReadingEventInit" -- wpt-commits: b551484d02846d38e186b25f0c443db76fe5da5c wpt-pr: 17336 UltraBlame original commit: 761cec8b2feccd2c2f4693a60931044700fa5a9a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…ent and NFCReadingEventInit., a=testonly Automatic update from web-platform-tests [webnfc] Introduce IDLs for NFCReadingEvent and NFCReadingEventInit. This CL introduces IDLs for NFCReadingEvent and NFCReadingEventInit interfaces, and updates the baseline of relevant wpt tests. http://w3c.github.io/web-nfc/#dom-nfcreadingevent The corresponding spec changes were introduced in w3c/web-nfc#179 w3c/web-nfc#227 BUG=520391 Change-Id: If2090d73ce746208a9e535fe31b6d52a9940d2fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655092 Commit-Queue: Leon Han <leon.hanintel.com> Reviewed-by: Kentaro Hara <harakenchromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumikintel.com> Reviewed-by: Reilly Grant <reillygchromium.org> Cr-Commit-Position: refs/heads/master{#679910} -- wpt-commits: 239561ebf7630cd4419dc8cea83606f27062bf87 wpt-pr: 17410 UltraBlame original commit: 26f95d4d38bd63485c2ec88ef04ed124dff979c5
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
Automatic update from web-platform-tests Adapt to web-nfc latest spec (#17336) * Adapt to web-nfc latest spec Spec change in #w3c/web-nfc/pull/227 - Move "serialNumber" from "NDEFMessage" to "NFCReadingEvent"/"NFCReadingEventInit" -- wpt-commits: b551484d02846d38e186b25f0c443db76fe5da5c wpt-pr: 17336 UltraBlame original commit: 761cec8b2feccd2c2f4693a60931044700fa5a9a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…ent and NFCReadingEventInit., a=testonly Automatic update from web-platform-tests [webnfc] Introduce IDLs for NFCReadingEvent and NFCReadingEventInit. This CL introduces IDLs for NFCReadingEvent and NFCReadingEventInit interfaces, and updates the baseline of relevant wpt tests. http://w3c.github.io/web-nfc/#dom-nfcreadingevent The corresponding spec changes were introduced in w3c/web-nfc#179 w3c/web-nfc#227 BUG=520391 Change-Id: If2090d73ce746208a9e535fe31b6d52a9940d2fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655092 Commit-Queue: Leon Han <leon.hanintel.com> Reviewed-by: Kentaro Hara <harakenchromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumikintel.com> Reviewed-by: Reilly Grant <reillygchromium.org> Cr-Commit-Position: refs/heads/master{#679910} -- wpt-commits: 239561ebf7630cd4419dc8cea83606f27062bf87 wpt-pr: 17410 UltraBlame original commit: 26f95d4d38bd63485c2ec88ef04ed124dff979c5
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
Automatic update from web-platform-tests Adapt to web-nfc latest spec (#17336) * Adapt to web-nfc latest spec Spec change in #w3c/web-nfc/pull/227 - Move "serialNumber" from "NDEFMessage" to "NFCReadingEvent"/"NFCReadingEventInit" -- wpt-commits: b551484d02846d38e186b25f0c443db76fe5da5c wpt-pr: 17336 UltraBlame original commit: 761cec8b2feccd2c2f4693a60931044700fa5a9a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…ent and NFCReadingEventInit., a=testonly Automatic update from web-platform-tests [webnfc] Introduce IDLs for NFCReadingEvent and NFCReadingEventInit. This CL introduces IDLs for NFCReadingEvent and NFCReadingEventInit interfaces, and updates the baseline of relevant wpt tests. http://w3c.github.io/web-nfc/#dom-nfcreadingevent The corresponding spec changes were introduced in w3c/web-nfc#179 w3c/web-nfc#227 BUG=520391 Change-Id: If2090d73ce746208a9e535fe31b6d52a9940d2fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655092 Commit-Queue: Leon Han <leon.hanintel.com> Reviewed-by: Kentaro Hara <harakenchromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumikintel.com> Reviewed-by: Reilly Grant <reillygchromium.org> Cr-Commit-Position: refs/heads/master{#679910} -- wpt-commits: 239561ebf7630cd4419dc8cea83606f27062bf87 wpt-pr: 17410 UltraBlame original commit: 26f95d4d38bd63485c2ec88ef04ed124dff979c5
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jun 1, 2024
…ent and NFCReadingEventInit., a=testonly Automatic update from web-platform-tests [webnfc] Introduce IDLs for NFCReadingEvent and NFCReadingEventInit. This CL introduces IDLs for NFCReadingEvent and NFCReadingEventInit interfaces, and updates the baseline of relevant wpt tests. http://w3c.github.io/web-nfc/#dom-nfcreadingevent The corresponding spec changes were introduced in w3c/web-nfc#179 w3c/web-nfc#227 BUG=520391 Change-Id: If2090d73ce746208a9e535fe31b6d52a9940d2fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655092 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#679910} -- wpt-commits: 239561ebf7630cd4419dc8cea83606f27062bf87 wpt-pr: 17410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.