Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using Adapter in API #66

Closed
kenchris opened this issue Oct 15, 2015 · 1 comment · Fixed by #88
Closed

Avoid using Adapter in API #66

kenchris opened this issue Oct 15, 2015 · 1 comment · Fixed by #88
Labels
F2F tag-tracker Group bringing to attention of the TAG, or tracked by the TAG but not needing response.

Comments

@kenchris
Copy link
Contributor

https://github.com/w3ctag/spec-reviews/blob/master/2015/10/nfc-feedback.md

...avoid use of the word "Adapter" (which felt foreign to me). Suggestion: navigator.requestNFC() --- instead of navigator.nfc.requestAdapter()
@zolkis
Copy link
Contributor

zolkis commented Oct 15, 2015

No strong opinion on this. Fine with navigator.requestNFC().

However, we have to continue talking about the notion of Adapter in the spec, similarly Bluetooth will likely need to maintain the notion. Something to be discussed on the F2F.

@zolkis zolkis added the F2F label Oct 15, 2015
@zolkis zolkis mentioned this issue Oct 15, 2015
Closed
zolkis added a commit to zolkis/web-nfc that referenced this issue Nov 4, 2015
@zolkis
Fix w3c#66, w3c#67, w3c#68. Remove NFCAdapter. Simplify nfc namespace…
2257984 
…. Use the merged NFC adapter concept for multiple adapters. Update examples.
@zolkis zolkis mentioned this issue Nov 4, 2015
Merged
@zolkis zolkis closed this as completed in #88 Nov 6, 2015
@plehegar plehegar added the tag-tracker Group bringing to attention of the TAG, or tracked by the TAG but not needing response. label Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
F2F tag-tracker Group bringing to attention of the TAG, or tracked by the TAG but not needing response.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TAG review comments. zolkis/web-nfc
3 participants
@zolkis @kenchris @plehegar