Fix TAG review comments. #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3c#84. Handle push related TAG review comments: simplified and aligned push message, optional push options with sensible defaults, improved push and cancelPush steps, option for suspending watches during push(), editorials.
|
Looks like the changes didn't update the comments here. You need to look at |
|
Examples need to be synchronized with latest changes. navigator.nfc.watch() for instance. |
zolkis
force-pushed
the
gh-pages
branch
2 times, most recently
from
e872e74
to
259eebd
Compare
…eb NFC Id creation.
|
Editors believe the TAG review comments have been addressed. |
This was referenced Nov 6, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #66, #67, #68: Remove NFCAdapter. Simplify nfc namespace. Use the merged NFC adapter concept for multiple adapters. Update examples.
Fix #69, #70, #73, #77, #80, #81, #82, #83, #84. Handle push related TAG review comments: simplified and aligned push message, optional push options with sensible defaults, improved push and cancelPush steps, option for suspending watches during push(), editorials.
Fix #71, #83, #85. Handle watch related TAG review comments: fix IDL for unwatch(), reverse param order for watch() and make options optional, make cancelPush target optional.