Replace SecurityError with NotAllowedError. #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As commit-aa50e6e193a repaced SecurityError with NotAllowedError, push algorithm should be consistent with NFCReader::Start().
|
The original commit: aa50e6e |
|
@kenchris sorry for the mistake, this is the updated one. |
kenchris
approved these changes
Jun 25, 2019
|
Thanks! Merging. |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 26, 2019
According to the Spec, this CL adjusted some error types for NFC hardware not supported and permission not allowed cases. Original changes in Spec are listed as follows. w3c/web-nfc@aa50e6e w3c/web-nfc#236 Bug: 520391 Change-Id: Ib4b017c0f3fcb71b030700f6b89a6ba3d76ae749
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 26, 2019
According to the Spec, this CL adjusted some error types for NFC hardware not supported and permission not allowed cases. Original changes in Spec are listed as follows. w3c/web-nfc@aa50e6e w3c/web-nfc#236 Bug: 520391 Change-Id: Ib4b017c0f3fcb71b030700f6b89a6ba3d76ae749
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 2, 2019
According to the Spec, this CL adjusted some error types for NFC hardware not supported and permission not allowed cases. Original changes in Spec are listed as follows. w3c/web-nfc@aa50e6e w3c/web-nfc#236 Bug: 520391 Change-Id: Ib4b017c0f3fcb71b030700f6b89a6ba3d76ae749
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 3, 2019
According to the Spec, this CL adjusted some error types for NFC hardware not supported and permission not allowed cases. Original changes in Spec are listed as follows. w3c/web-nfc@aa50e6e w3c/web-nfc#236 Bug: 520391 Change-Id: Ib4b017c0f3fcb71b030700f6b89a6ba3d76ae749
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 3, 2019
According to the Spec, this CL adjusted some error types for NFC hardware not supported and permission not allowed cases. Original changes in Spec are listed as follows. w3c/web-nfc@aa50e6e w3c/web-nfc#236 Bug: 520391 Change-Id: Ib4b017c0f3fcb71b030700f6b89a6ba3d76ae749
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 3, 2019
According to the Spec, this CL adjusted some error types for NFC hardware not supported and permission not allowed cases. Original changes in Spec are listed as follows. w3c/web-nfc@aa50e6e w3c/web-nfc#236 Bug: 520391 Change-Id: Ib4b017c0f3fcb71b030700f6b89a6ba3d76ae749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677736 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#674390}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 3, 2019
According to the Spec, this CL adjusted some error types for NFC hardware not supported and permission not allowed cases. Original changes in Spec are listed as follows. w3c/web-nfc@aa50e6e w3c/web-nfc#236 Bug: 520391 Change-Id: Ib4b017c0f3fcb71b030700f6b89a6ba3d76ae749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677736 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#674390}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 24, 2019
…W not supported case., a=testonly Automatic update from web-platform-tests [webnfc] Adjust returned error for NFC HW not supported case. According to the Spec, this CL adjusted some error types for NFC hardware not supported and permission not allowed cases. Original changes in Spec are listed as follows. w3c/web-nfc@aa50e6e w3c/web-nfc#236 Bug: 520391 Change-Id: Ib4b017c0f3fcb71b030700f6b89a6ba3d76ae749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677736 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#674390} -- wpt-commits: 213380b1fbb9305d64b72baedee710035689a50d wpt-pr: 17519
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jul 25, 2019
…W not supported case., a=testonly Automatic update from web-platform-tests [webnfc] Adjust returned error for NFC HW not supported case. According to the Spec, this CL adjusted some error types for NFC hardware not supported and permission not allowed cases. Original changes in Spec are listed as follows. w3c/web-nfc@aa50e6e w3c/web-nfc#236 Bug: 520391 Change-Id: Ib4b017c0f3fcb71b030700f6b89a6ba3d76ae749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677736 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#674390} -- wpt-commits: 213380b1fbb9305d64b72baedee710035689a50d wpt-pr: 17519
Closed
natechapin
pushed a commit
to natechapin/wpt
that referenced
this pull request
Aug 23, 2019
According to the Spec, this CL adjusted some error types for NFC hardware not supported and permission not allowed cases. Original changes in Spec are listed as follows. w3c/web-nfc@aa50e6e w3c/web-nfc#236 Bug: 520391 Change-Id: Ib4b017c0f3fcb71b030700f6b89a6ba3d76ae749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677736 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#674390}
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…W not supported case., a=testonly Automatic update from web-platform-tests [webnfc] Adjust returned error for NFC HW not supported case. According to the Spec, this CL adjusted some error types for NFC hardware not supported and permission not allowed cases. Original changes in Spec are listed as follows. w3c/web-nfc@aa50e6e w3c/web-nfc#236 Bug: 520391 Change-Id: Ib4b017c0f3fcb71b030700f6b89a6ba3d76ae749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677736 Commit-Queue: Donna Wu <donna.wuintel.com> Reviewed-by: Kinuko Yasuda <kinukochromium.org> Reviewed-by: Reilly Grant <reillygchromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumikintel.com> Cr-Commit-Position: refs/heads/master{#674390} -- wpt-commits: 213380b1fbb9305d64b72baedee710035689a50d wpt-pr: 17519 UltraBlame original commit: 0d6069dc49b025be4082cc0ebeaca1ef5b99e873
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…W not supported case., a=testonly Automatic update from web-platform-tests [webnfc] Adjust returned error for NFC HW not supported case. According to the Spec, this CL adjusted some error types for NFC hardware not supported and permission not allowed cases. Original changes in Spec are listed as follows. w3c/web-nfc@aa50e6e w3c/web-nfc#236 Bug: 520391 Change-Id: Ib4b017c0f3fcb71b030700f6b89a6ba3d76ae749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677736 Commit-Queue: Donna Wu <donna.wuintel.com> Reviewed-by: Kinuko Yasuda <kinukochromium.org> Reviewed-by: Reilly Grant <reillygchromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumikintel.com> Cr-Commit-Position: refs/heads/master{#674390} -- wpt-commits: 213380b1fbb9305d64b72baedee710035689a50d wpt-pr: 17519 UltraBlame original commit: 0d6069dc49b025be4082cc0ebeaca1ef5b99e873
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…W not supported case., a=testonly Automatic update from web-platform-tests [webnfc] Adjust returned error for NFC HW not supported case. According to the Spec, this CL adjusted some error types for NFC hardware not supported and permission not allowed cases. Original changes in Spec are listed as follows. w3c/web-nfc@aa50e6e w3c/web-nfc#236 Bug: 520391 Change-Id: Ib4b017c0f3fcb71b030700f6b89a6ba3d76ae749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677736 Commit-Queue: Donna Wu <donna.wuintel.com> Reviewed-by: Kinuko Yasuda <kinukochromium.org> Reviewed-by: Reilly Grant <reillygchromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumikintel.com> Cr-Commit-Position: refs/heads/master{#674390} -- wpt-commits: 213380b1fbb9305d64b72baedee710035689a50d wpt-pr: 17519 UltraBlame original commit: 0d6069dc49b025be4082cc0ebeaca1ef5b99e873
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As commit-aa50e6e193a repaced SecurityError with NotAllowedError,
push algorithm should be consistent with NFCReader::Start().