Remove URL constraint for record id #446

beaufortfrancois · 2019-11-25T08:23:06Z

As discussed in #444 (comment), this PR removes binding record ids with the hostname of the current web page.

zolkis · 2019-11-25T08:29:27Z

index.html

    </p>
    <p>
      The example allows reading and pushing to both peers and tags,
      whichever one is tapped first.
    </p>
    <pre class="example">
      const reader = new NDEFReader();
-      await reader.scan({ id: "https://mygame.com/mypath/mygame" });
+      await reader.scan({ id: "my-game-progress" });


It is not excluded someone could use a URL as id, though.

I've edited example description at 7c2d2c1

kenchris · 2019-11-25T08:29:42Z

index.html

    </p>
    <p>
      The example allows reading and pushing to both peers and tags,
      whichever one is tapped first.
    </p>
    <pre class="example">
      const reader = new NDEFReader();
-      await reader.scan({ id: "https://mygame.com/mypath/mygame" });
+      await reader.scan({ id: "my-game-progress" });


according to NDEF spec ids are supposed to be urls

semanticly it is an url (can be relative so you can say the examples are) but we should at least note that in a note or something

Right, I forgot about that.

I've edited example description at 7c2d2c1

Where we introduce the id field, are we making clear that it is a url?

updated example looks good

Where we introduce the id field, are we making clear that it is a url?

I've updated id introduction at a78d5fb

If we include relative URLs, what they are relative to, and how does the implementation add the base URL when the record is written?

The implementation does not add any base URL but just writes the relative URL as is.

zolkis · 2019-11-25T08:31:56Z

index.html

@@ -3327,111 +3249,6 @@ <h3><dfn>Writing or pushing content</dfn></h3>
        "`*/*json`", on the other hand, matches both.
      </div>
    </section>
-    <section> <h3>URL patterns</h3>


Hmm. A lot of work is gone... :)
Not sure it couldn't be useful at some point, but for now yes, it's to be removed.

I am not so certain. For people using URLs being able to use * is quite handy

How about waiting for web developers feedback in origin trials?
We can easily add it if people need it.

Sounds good. But how will people know there would be a possibility to use URL patterns and what are they? A note perhaps?

zolkis · 2019-11-25T08:33:24Z

index.html

@@ -3640,8 +3451,7 @@ <h3><dfn>Writing or pushing content</dfn></h3>
        <ol>
          <li>
            If |reader|.<a>[[\Id]]</a> is [= dictionary member/present =]
-            and doesn't <a href="#dfn-match-record-identifier-with-url-pattern">match</a>
-            any |record:NDEFRecord|'s id where |record|
+            and it is not equal to any |record|'s id where |record|


Fair enough, an id should be compared for equality, not for partial match. Good.

zolkis

Thanks!

The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. This CL is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. 4. Removes NDEFMessage{Init}#url and old impl of the author record. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: Ie6f5b2978f78676c3aa607d09e7ffd5bbb5005d8

leonhsl

lgtm

leonhsl · 2019-11-26T04:45:35Z

index.html

    </p>
    <p>
      The example allows reading and pushing to both peers and tags,
      whichever one is tapped first.
    </p>
    <pre class="example">
      const reader = new NDEFReader();
-      await reader.scan({ id: "https://mygame.com/mypath/mygame" });
+      await reader.scan({ id: "my-game-progress" });


The implementation does not add any base URL but just writes the relative URL as is.

…hor record url The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. crrev.com/c/1928891 is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. This CL make this step done. 4. Removes NDEFMessage{Init}#url and old impl of the author record. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: I8d7165bc2833501ce96187ada9f8c3b5053b3bad

The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. crrev.com/c/1928891 is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. Done by crrev.com/c/1936187. 4. Removes NDEFMessage{Init}#url and old impl of the author record. This CL. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: Id1c29d980426a5559fd6e30aa0fc95b268d8e96c

The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. This CL is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. 4. Removes NDEFMessage{Init}#url and old impl of the author record. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: Ie6f5b2978f78676c3aa607d09e7ffd5bbb5005d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928891 Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#720792}

…hor record url The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. crrev.com/c/1928891 is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. This CL make this step done. 4. Removes NDEFMessage{Init}#url and old impl of the author record. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: I8d7165bc2833501ce96187ada9f8c3b5053b3bad

The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. crrev.com/c/1928891 is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. Done by crrev.com/c/1936187. 4. Removes NDEFMessage{Init}#url and old impl of the author record. This CL. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: Id1c29d980426a5559fd6e30aa0fc95b268d8e96c

…hor record url The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. crrev.com/c/1928891 is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. This CL make this step done. 4. Removes NDEFMessage{Init}#url and old impl of the author record. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: I8d7165bc2833501ce96187ada9f8c3b5053b3bad

The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. crrev.com/c/1928891 is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. Done by crrev.com/c/1936187. 4. Removes NDEFMessage{Init}#url and old impl of the author record. This CL. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: Id1c29d980426a5559fd6e30aa0fc95b268d8e96c

…hor record url The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. crrev.com/c/1928891 is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. This CL. 4. Removes NDEFMessage{Init}#url and old impl of the author record. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: I8d7165bc2833501ce96187ada9f8c3b5053b3bad

…hor record url The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. crrev.com/c/1928891 is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. This CL. 4. Removes NDEFMessage{Init}#url and old impl of the author record. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: I8d7165bc2833501ce96187ada9f8c3b5053b3bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936187 Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#722901}

…support writing record id, a=testonly Automatic update from web-platform-tests [webnfc] Introduce NDEFRecordInit#id to support writing record id The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. This CL is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. 4. Removes NDEFMessage{Init}#url and old impl of the author record. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: Ie6f5b2978f78676c3aa607d09e7ffd5bbb5005d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928891 Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#720792} -- wpt-commits: d9ee4f3e4ef4792b085687584981611e0b74f003 wpt-pr: 20391

…support writing record id, a=testonly Automatic update from web-platform-tests [webnfc] Introduce NDEFRecordInit#id to support writing record id The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. This CL is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. 4. Removes NDEFMessage{Init}#url and old impl of the author record. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: Ie6f5b2978f78676c3aa607d09e7ffd5bbb5005d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928891 Reviewed-by: François Beaufort <beaufort.francoisgmail.com> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumikintel.com> Commit-Queue: Leon Han <leon.hanintel.com> Cr-Commit-Position: refs/heads/master{#720792} -- wpt-commits: d9ee4f3e4ef4792b085687584981611e0b74f003 wpt-pr: 20391 UltraBlame original commit: 014ed6bd538dec3df1db611a662cffbda8966741

The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. crrev.com/c/1928891 is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. Done by crrev.com/c/1936187. 4. Removes NDEFMessage{Init}#url and old impl of the author record. This CL. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: Id1c29d980426a5559fd6e30aa0fc95b268d8e96c

The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. crrev.com/c/1928891 is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. Done by crrev.com/c/1936187. 4. Removes NDEFMessage{Init}#url and old impl of the author record. This CL. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: Id1c29d980426a5559fd6e30aa0fc95b268d8e96c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938835 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#723252}

…ecord ids rather than the author record url, a=testonly Automatic update from web-platform-tests [webnfc] Make NFCScanOptions#id filter record ids rather than the author record url The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. crrev.com/c/1928891 is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. This CL. 4. Removes NDEFMessage{Init}#url and old impl of the author record. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: I8d7165bc2833501ce96187ada9f8c3b5053b3bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936187 Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#722901} -- wpt-commits: e9e13796b23cc62b0e7f7163077665a32fba6c1f wpt-pr: 20449

…d old impl of the author record., a=testonly Automatic update from web-platform-tests [webnfc] Remove NDEFMessage{Init}#url and old impl of the author record. The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. crrev.com/c/1928891 is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. Done by crrev.com/c/1936187. 4. Removes NDEFMessage{Init}#url and old impl of the author record. This CL. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: Id1c29d980426a5559fd6e30aa0fc95b268d8e96c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938835 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#723252} -- wpt-commits: fa41b43ac93bc2fdc2427a4378dc3754d483cdda wpt-pr: 20472

…ecord ids rather than the author record url, a=testonly Automatic update from web-platform-tests [webnfc] Make NFCScanOptions#id filter record ids rather than the author record url The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. crrev.com/c/1928891 is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. This CL. 4. Removes NDEFMessage{Init}#url and old impl of the author record. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: I8d7165bc2833501ce96187ada9f8c3b5053b3bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936187 Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumikintel.com> Reviewed-by: Daniel Cheng <dchengchromium.org> Commit-Queue: Leon Han <leon.hanintel.com> Cr-Commit-Position: refs/heads/master{#722901} -- wpt-commits: e9e13796b23cc62b0e7f7163077665a32fba6c1f wpt-pr: 20449 UltraBlame original commit: b55ce5cbebc73634b77bc956264bf4bed3c6c053

…d old impl of the author record., a=testonly Automatic update from web-platform-tests [webnfc] Remove NDEFMessage{Init}#url and old impl of the author record. The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. crrev.com/c/1928891 is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. Done by crrev.com/c/1936187. 4. Removes NDEFMessage{Init}#url and old impl of the author record. This CL. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: Id1c29d980426a5559fd6e30aa0fc95b268d8e96c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938835 Commit-Queue: Leon Han <leon.hanintel.com> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumikintel.com> Reviewed-by: Daniel Cheng <dchengchromium.org> Reviewed-by: François Beaufort <beaufort.francoisgmail.com> Cr-Commit-Position: refs/heads/master{#723252} -- wpt-commits: fa41b43ac93bc2fdc2427a4378dc3754d483cdda wpt-pr: 20472 UltraBlame original commit: aaf1990089423f230eff5bfb4fb2bad3b9f60ba8

…ecord ids rather than the author record url, a=testonly Automatic update from web-platform-tests [webnfc] Make NFCScanOptions#id filter record ids rather than the author record url The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. crrev.com/c/1928891 is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. This CL. 4. Removes NDEFMessage{Init}#url and old impl of the author record. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: I8d7165bc2833501ce96187ada9f8c3b5053b3bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936187 Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumikintel.com> Reviewed-by: Daniel Cheng <dchengchromium.org> Commit-Queue: Leon Han <leon.hanintel.com> Cr-Commit-Position: refs/heads/master{#722901} -- wpt-commits: e9e13796b23cc62b0e7f7163077665a32fba6c1f wpt-pr: 20449 UltraBlame original commit: b55ce5cbebc73634b77bc956264bf4bed3c6c053

…d old impl of the author record., a=testonly Automatic update from web-platform-tests [webnfc] Remove NDEFMessage{Init}#url and old impl of the author record. The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. crrev.com/c/1928891 is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. Done by crrev.com/c/1936187. 4. Removes NDEFMessage{Init}#url and old impl of the author record. This CL. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: Id1c29d980426a5559fd6e30aa0fc95b268d8e96c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938835 Commit-Queue: Leon Han <leon.hanintel.com> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumikintel.com> Reviewed-by: Daniel Cheng <dchengchromium.org> Reviewed-by: François Beaufort <beaufort.francoisgmail.com> Cr-Commit-Position: refs/heads/master{#723252} -- wpt-commits: fa41b43ac93bc2fdc2427a4378dc3754d483cdda wpt-pr: 20472 UltraBlame original commit: aaf1990089423f230eff5bfb4fb2bad3b9f60ba8

…ecord ids rather than the author record url, a=testonly Automatic update from web-platform-tests [webnfc] Make NFCScanOptions#id filter record ids rather than the author record url The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. crrev.com/c/1928891 is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. This CL. 4. Removes NDEFMessage{Init}#url and old impl of the author record. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: I8d7165bc2833501ce96187ada9f8c3b5053b3bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936187 Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumikintel.com> Reviewed-by: Daniel Cheng <dchengchromium.org> Commit-Queue: Leon Han <leon.hanintel.com> Cr-Commit-Position: refs/heads/master{#722901} -- wpt-commits: e9e13796b23cc62b0e7f7163077665a32fba6c1f wpt-pr: 20449 UltraBlame original commit: b55ce5cbebc73634b77bc956264bf4bed3c6c053

…d old impl of the author record., a=testonly Automatic update from web-platform-tests [webnfc] Remove NDEFMessage{Init}#url and old impl of the author record. The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. crrev.com/c/1928891 is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. Done by crrev.com/c/1936187. 4. Removes NDEFMessage{Init}#url and old impl of the author record. This CL. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: Id1c29d980426a5559fd6e30aa0fc95b268d8e96c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938835 Commit-Queue: Leon Han <leon.hanintel.com> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumikintel.com> Reviewed-by: Daniel Cheng <dchengchromium.org> Reviewed-by: François Beaufort <beaufort.francoisgmail.com> Cr-Commit-Position: refs/heads/master{#723252} -- wpt-commits: fa41b43ac93bc2fdc2427a4378dc3754d483cdda wpt-pr: 20472 UltraBlame original commit: aaf1990089423f230eff5bfb4fb2bad3b9f60ba8

…ecord ids rather than the author record url, a=testonly Automatic update from web-platform-tests [webnfc] Make NFCScanOptions#id filter record ids rather than the author record url The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. crrev.com/c/1928891 is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. This CL. 4. Removes NDEFMessage{Init}#url and old impl of the author record. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: I8d7165bc2833501ce96187ada9f8c3b5053b3bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936187 Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#722901} -- wpt-commits: e9e13796b23cc62b0e7f7163077665a32fba6c1f wpt-pr: 20449

…d old impl of the author record., a=testonly Automatic update from web-platform-tests [webnfc] Remove NDEFMessage{Init}#url and old impl of the author record. The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. crrev.com/c/1928891 is focused on impl in Blink, with the following CLs focused on impl in Device Service. crrev.com/c/1910906 crrev.com/c/1911385 crrev.com/c/1915940 crrev.com/c/1916261 3. Introduces NFCScanOptions#id and filters records by it when scanning. Done by crrev.com/c/1936187. 4. Removes NDEFMessage{Init}#url and old impl of the author record. This CL. The spec changes: w3c/web-nfc#338 w3c/web-nfc#340 w3c/web-nfc#446 BUG=520391 Change-Id: Id1c29d980426a5559fd6e30aa0fc95b268d8e96c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938835 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#723252} -- wpt-commits: fa41b43ac93bc2fdc2427a4378dc3754d483cdda wpt-pr: 20472

Remove URL constraint for record id

94867ab

beaufortfrancois mentioned this pull request Nov 25, 2019

Keep (how?) or remove the record id? #445

Closed

beaufortfrancois requested review from zolkis and kenchris November 25, 2019 08:23

zolkis reviewed Nov 25, 2019

View reviewed changes

kenchris reviewed Nov 25, 2019

View reviewed changes

zolkis reviewed Nov 25, 2019

View reviewed changes

zolkis approved these changes Nov 25, 2019

View reviewed changes

beaufortfrancois added 2 commits November 25, 2019 09:51

Address @kenchris feedback

7c2d2c1

Address @kenchris feedback | part 2

a78d5fb

kenchris approved these changes Nov 25, 2019

View reviewed changes

beaufortfrancois merged commit 23e8e3b into w3c:gh-pages Nov 25, 2019

beaufortfrancois deleted the id branch November 25, 2019 09:07

chromium-wpt-export-bot mentioned this pull request Nov 26, 2019

[webnfc] Introduce NDEFRecordInit#id to support writing record id web-platform-tests/wpt#20391

Merged

leonhsl reviewed Nov 26, 2019

View reviewed changes

chromium-wpt-export-bot mentioned this pull request Nov 26, 2019

[webnfc] Make NFCScanOptions#id filter record ids rather than the author record url web-platform-tests/wpt#20449

Merged

chromium-wpt-export-bot mentioned this pull request Nov 27, 2019

[webnfc] Remove NDEFMessage{Init}#url and old impl of the author record. web-platform-tests/wpt#20472

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove URL constraint for record id #446

Remove URL constraint for record id #446

beaufortfrancois commented Nov 25, 2019 •

edited by pr-preview bot

Loading

zolkis Nov 25, 2019

beaufortfrancois Nov 25, 2019

kenchris Nov 25, 2019

kenchris Nov 25, 2019

kenchris Nov 25, 2019

zolkis Nov 25, 2019

beaufortfrancois Nov 25, 2019

kenchris Nov 25, 2019

kenchris Nov 25, 2019

beaufortfrancois Nov 25, 2019

zolkis Nov 25, 2019

leonhsl Nov 26, 2019

zolkis Nov 25, 2019

kenchris Nov 25, 2019

beaufortfrancois Nov 25, 2019 •

edited

Loading

zolkis Nov 25, 2019 •

edited

Loading

zolkis Nov 25, 2019

zolkis left a comment

leonhsl left a comment

leonhsl Nov 26, 2019

Remove URL constraint for record id #446

Remove URL constraint for record id #446

Conversation

beaufortfrancois commented Nov 25, 2019 • edited by pr-preview bot Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

beaufortfrancois Nov 25, 2019 • edited Loading

Choose a reason for hiding this comment

zolkis Nov 25, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zolkis left a comment

Choose a reason for hiding this comment

leonhsl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

beaufortfrancois commented Nov 25, 2019 •

edited by pr-preview bot

Loading

beaufortfrancois Nov 25, 2019 •

edited

Loading

zolkis Nov 25, 2019 •

edited

Loading