Fix #470: remove adding effective domain #474

zolkis · 2019-12-13T15:31:13Z

Signed-off-by: Zoltan Kis zoltan.kis@intel.com

Preview | Diff

index.html

zolkis · 2019-12-13T15:38:39Z

index.html

-          <a data-cite="url#concept-url-serializer">serialization</a> of the
-          <a data-cite="html">effective domain</a> of the {{Document/origin}}.
+          If |type| does not match the `custom-type` definition from the
+          <a>external type name ABNF</a>, return `false`.


could we improve this text? "match ABNF" stinks.

Yeah, its basically ASCII without whitespaces and a few extra special chars. You can write an algorithm.

Is ASCII

has whitespaces

Contains other non-valid characters

And no control characters

Actually they accept a very weird selection!

0x24 $
0x27 '
0x28 (
0x29 )
0x2A *
0x2B +
0x2C ,
0x2D -
0x2E .
0x3B ;
0x3D =
0x40 @
0x5F _

URL spec uses wording like

Otherwise, if byte is 0x25 (%) and the next two bytes after byte in input are not in the ranges 0x30 (0) to 0x39 (9), 0x41 (A) to 0x46 (F), and 0x61 (a) to 0x66 (f), all inclusive, append byte to output.

and

The URL code points are ASCII alphanumeric, U+0021 (!), U+0024 ($), U+0026 (&), U+0027 ('), U+0028 LEFT PARENTHESIS, U+0029 RIGHT PARENTHESIS, U+002A (*), U+002B (+), U+002C (,), U+002D (-), U+002E (.), U+002F (/), U+003A (:), U+003B (;), U+003D (=), U+003F (?), U+0040 (@), U+005F (_), U+007E (~), and code points in the range U+00A0 to U+10FFFD, inclusive, excluding surrogates and noncharacters.

That can be used for description :)

The type code points are ASCII alphanumeric, U+0024 ($), U+0027 ('), U+0028 LEFT PARENTHESIS, U+0029 RIGHT PARENTHESIS, U+002A (*), U+002B (+), U+002C (,), U+002D (-), U+002E (.), U+003B (;), U+003D (=), U+0040 (@), U+005F (_).

I have updated (amended) the steps, please check again.

index.html

kenchris · 2019-12-16T09:25:56Z

index.html

+        In addition to [=well known type names=] it is also possible for
+        organizations to create a own custom <dfn>external type name</dfn> that
+        which is a string consisting of a domain name and a custom ASCII name,
+        separated by a colon (`':'`). The string may not contain any whitespace


I think my other comment is probably better

This is not the place we specify the algorithm, and we should avoid repeating that complex thing. So either we say "satisfies the validate external type name steps", or we give a short summary in words.

In addition to [=well known type names=] it is also possible for organizations to create a own custom external type name which is a string consisting of a domain name and a developer created type.

The developer created type code points are ASCII alphanumeric, U+0024 ($), U+0027 ('), U+0028 LEFT PARENTHESIS, U+0029 RIGHT PARENTHESIS, U+002A (*), U+002B (+), U+002C (,), U+002D (-), U+002E (.), U+003B (;), U+003D (=), U+0040 (@), U+005F (_).

That seems fine and aligned with other specs.

The NFC spec made it complex

Can we keep that enumeration in the validate external type steps only, and refer to them from here?

URL specs uses U+00** when describing and 0x** when used in algos. I thikn this is fine. It is a spec, not documentation :)

OK, I took another attempt on it (amend).

Removed the validation specific part.

index.html

kenchris · 2019-12-16T09:40:09Z

index.html

-          <a data-cite="url#concept-url-serializer">serialization</a> of the
-          <a data-cite="html">effective domain</a> of the {{Document/origin}}.
+          If |type| contains code points that are not [=ASCII alphanumeric=], or
+          `U+0024` (`$`), `U+0027` (`'`), `U+0028` (`(`), `U+0029` (`)`),


interestingly URL specs writes out (() as LEFT PARENTESIS etc

We should probably follow for consistency

Hmm. Strange. Should we use the same? (outsider reader might be confused why)

You can say U+0029 RIGHT PARENTHESIS ()) - that is allowed

but I agree that it is ugly and that U+0029 RIGHT PARENTHESIS seems fine. We will link code points to INFRA spec anyway so we are good

We definitely need to follow INFRA spec... everyone is moving to do that

kenchris · 2019-12-16T09:42:36Z

index.html

+          If not found, return `false`.
+        </li>
+        <li>
+          Let |domain| be the part of |input| preceding the last colon,


cannot refer to colon here. Need to store the index above.

Let colonIndex be the last ...

Yeah, it's still pseudocode, and it's not more clear than before (when we just want to say use the last colon), but fine.

kenchris · 2019-12-16T09:43:59Z

index.html

+        organizations to create a own custom <dfn>external type name</dfn>
+        which is a string consisting of a domain name and a custom ASCII name,
+        separated by a colon (`':'`) that satisfies the
+        <a>validate external type</a> steps.


I still think it makes more sense to just write it out here instead of the satisfied wording

kenchris · 2019-12-16T09:45:05Z

index.html

+        In addition to [=well known type names=] it is also possible for
+        organizations to create a own custom <dfn>external type name</dfn>
+        which is a string consisting of a domain name and a custom ASCII name,
+        separated by a colon (`':'`) that satisfies the


should we write the U+00 number here?

Fixed everywhere.

index.html

beaufortfrancois · 2019-12-16T11:31:16Z

index.html

+        organizations to create a own custom <dfn>external type name</dfn>
+        which is a string consisting of a domain name and a custom ASCII name,
+        separated by a colon (`':'`) that satisfies the
+        <a>validate external type</a> steps.


beaufortfrancois · 2019-12-16T11:32:14Z

index.html

      </dl>
+      <p>
+        In addition to [=well known type names=] it is also possible for
+        organizations to create a own custom <dfn>external type name</dfn>


Nit: remove own

Right! Actually I removed it recently, strange.

beaufortfrancois · 2019-12-16T11:34:35Z

index.html

-            Validating domain name needs an algorithm.
-          </p>
+          Let  |colonIndex| be the last occurrence of `U+003A` (`:`) in |input|.
+          If a `U+003A` (`:`) is not found, return `false`.


Nit: Shall we swap the order of those two sentences?

I was thinking about that, but the way you write code, it's an error/exception handling. If I put it to the front, it's double pass if someone takes the steps literally. Maybe there is a better formulation?

except that it's the last occurrence of U+003A.

And then need to check if |domain| and |type| are defined, i.e. in the steps above we need to include "or otherwise null

Is it last though? We allow URLs but the scheme and port etc is not written down.

so we accept people to write "https://intel.com:8080:coolio" or actually "intel.com:coolio" - in the latter one there is only one : ever

This needs another round now. The sentence above doesn't handle the case when a colon is not found.

beaufortfrancois · 2019-12-16T11:35:45Z

index.html

-          <a data-cite="url#concept-url-serializer">serialization</a> of the
-          <a data-cite="html">effective domain</a> of the {{Document/origin}}.
+          If |type| contains code points that are not [=ASCII alphanumeric=], or
+          `U+0024` (`$`), `U+0027` (`'`), `U+0028` (`(`), `U+0029` (`)`),


Signed-off-by: Zoltan Kis <zoltan.kis@intel.com>

index.html

kenchris · 2019-12-16T13:06:06Z

Sorry for all the comments, this is getting there

Signed-off-by: Zoltan Kis <zoltan.kis@intel.com>

index.html

Signed-off-by: Zoltan Kis <zoltan.kis@intel.com>

The spec change: w3c/web-nfc#474 BUG=520391 Change-Id: If1e4a6513410f3705bec4da7b2cc514c209a3cd9

The spec change: w3c/web-nfc#474 BUG=520391 Change-Id: If1e4a6513410f3705bec4da7b2cc514c209a3cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978622 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#727853}

…ng external types, a=testonly Automatic update from web-platform-tests [webnfc] Implement the algo for validating external types The spec change: w3c/web-nfc#474 BUG=520391 Change-Id: If1e4a6513410f3705bec4da7b2cc514c209a3cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978622 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#727853} -- wpt-commits: 74efe51f1faaa2bf3ff91c10f05a4ad9615a1553 wpt-pr: 20885

zolkis commented Dec 13, 2019

View reviewed changes

index.html Outdated Show resolved Hide resolved

zolkis commented Dec 13, 2019

View reviewed changes

index.html Outdated Show resolved Hide resolved

zolkis commented Dec 13, 2019

View reviewed changes

index.html Outdated Show resolved Hide resolved

zolkis commented Dec 13, 2019

View reviewed changes

index.html Outdated Show resolved Hide resolved

zolkis commented Dec 13, 2019

View reviewed changes

index.html Outdated Show resolved Hide resolved

kenchris requested changes Dec 13, 2019

View reviewed changes

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

zolkis force-pushed the simplify-ext-rec-470 branch from 7185fec to ca5af2d Compare December 13, 2019 15:45

zolkis requested a review from kenchris December 15, 2019 22:18

beaufortfrancois reviewed Dec 16, 2019

View reviewed changes

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

zolkis mentioned this pull request Dec 16, 2019

reg-name ABNF is unspecified #350

Closed

kenchris reviewed Dec 16, 2019

View reviewed changes

index.html Outdated Show resolved Hide resolved

kenchris reviewed Dec 16, 2019

View reviewed changes

index.html Show resolved Hide resolved

zolkis force-pushed the simplify-ext-rec-470 branch from ca5af2d to 46c9bc7 Compare December 16, 2019 09:23

kenchris reviewed Dec 16, 2019

View reviewed changes

index.html Outdated Show resolved Hide resolved

kenchris reviewed Dec 16, 2019

View reviewed changes

index.html Outdated Show resolved Hide resolved

kenchris reviewed Dec 16, 2019

View reviewed changes

index.html Outdated Show resolved Hide resolved

zolkis force-pushed the simplify-ext-rec-470 branch from 46c9bc7 to 1c6461d Compare December 16, 2019 09:36

kenchris requested changes Dec 16, 2019

View reviewed changes

index.html Outdated Show resolved Hide resolved

zolkis force-pushed the simplify-ext-rec-470 branch from 1c6461d to 78d776c Compare December 16, 2019 09:38

kenchris reviewed Dec 16, 2019

View reviewed changes

index.html Show resolved Hide resolved

zolkis force-pushed the simplify-ext-rec-470 branch 2 times, most recently from a467abf to 3373cc3 Compare December 16, 2019 11:36

beaufortfrancois reviewed Dec 16, 2019

View reviewed changes

Fix w3c#470: remove adding effective domain

87f5311

Signed-off-by: Zoltan Kis <zoltan.kis@intel.com>

zolkis force-pushed the simplify-ext-rec-470 branch from 3373cc3 to 87f5311 Compare December 16, 2019 11:49

kenchris reviewed Dec 16, 2019

View reviewed changes

index.html Outdated Show resolved Hide resolved

kenchris reviewed Dec 16, 2019

View reviewed changes

index.html Outdated Show resolved Hide resolved

kenchris reviewed Dec 16, 2019

View reviewed changes

index.html Outdated Show resolved Hide resolved

zolkis added 2 commits December 16, 2019 15:25

Fix validate external type steps

bde91a9

Signed-off-by: Zoltan Kis <zoltan.kis@intel.com>

Fix link to forbidden code point

3bd2204

Signed-off-by: Zoltan Kis <zoltan.kis@intel.com>

zolkis force-pushed the simplify-ext-rec-470 branch from 23cd28b to 3bd2204 Compare December 16, 2019 13:31

kenchris reviewed Dec 16, 2019

View reviewed changes

index.html Outdated Show resolved Hide resolved

zolkis added 3 commits December 16, 2019 15:39

Improve validating local type names

2190266

Signed-off-by: Zoltan Kis <zoltan.kis@intel.com>

Fix usage of 'which'

3b2e05c

Signed-off-by: Zoltan Kis <zoltan.kis@intel.com>

Fix validate local type steps

89b3905

Signed-off-by: Zoltan Kis <zoltan.kis@intel.com>

kenchris approved these changes Dec 16, 2019

View reviewed changes

kenchris merged commit 7426f9f into w3c:gh-pages Dec 16, 2019

zolkis deleted the simplify-ext-rec-470 branch December 16, 2019 14:09

zolkis mentioned this pull request Dec 17, 2019

"typedef DOMString NDEFRecordType" is expected to be case sensitive or not? #331

Closed

chromium-wpt-export-bot mentioned this pull request Dec 20, 2019

[webnfc] Implement the algo for validating external types web-platform-tests/wpt#20885

Merged

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Dec 20, 2019

[webnfc] Implement the algo for validating external types

5a89d06

The spec change: w3c/web-nfc#474 BUG=520391 Change-Id: If1e4a6513410f3705bec4da7b2cc514c209a3cd9

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Dec 24, 2019

[webnfc] Implement the algo for validating external types

619fe3f

The spec change: w3c/web-nfc#474 BUG=520391 Change-Id: If1e4a6513410f3705bec4da7b2cc514c209a3cd9

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Dec 24, 2019

[webnfc] Implement the algo for validating external types

7545ff5

The spec change: w3c/web-nfc#474 BUG=520391 Change-Id: If1e4a6513410f3705bec4da7b2cc514c209a3cd9

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Dec 31, 2019

[webnfc] Implement the algo for validating external types

dfa8a6e

The spec change: w3c/web-nfc#474 BUG=520391 Change-Id: If1e4a6513410f3705bec4da7b2cc514c209a3cd9

sleevi mentioned this pull request Jan 3, 2020

Fix external type validation algorithm #511

Closed

Fix #470: remove adding effective domain #474

Fix #470: remove adding effective domain #474

Conversation

zolkis commented Dec 13, 2019 • edited by pr-preview bot Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kenchris Dec 16, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kenchris Dec 16, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kenchris Dec 16, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kenchris commented Dec 16, 2019

zolkis commented Dec 13, 2019 •

edited by pr-preview bot

Loading

kenchris Dec 16, 2019 •

edited

Loading

kenchris Dec 16, 2019 •

edited

Loading

kenchris Dec 16, 2019 •

edited

Loading