Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve scan promise after reader is activated #483

Merged
merged 1 commit into from Dec 23, 2019
Merged

Resolve scan promise after reader is activated #483

merged 1 commit into from Dec 23, 2019

Conversation

beaufortfrancois
Copy link
Collaborator

@beaufortfrancois beaufortfrancois commented Dec 23, 2019 •
edited by pr-preview bot

As suggested at #478 (comment), scan promise should resolve just after reader is added to activated reader objects.

Preview | Diff

@beaufortfrancois beaufortfrancois mentioned this pull request Dec 23, 2019
Closed
kenchris
kenchris reviewed Dec 23, 2019
View reviewed changes
Copy link
Contributor

@kenchris kenchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we return it as well? Or is that done above?

@beaufortfrancois
Copy link
Collaborator Author

It is done above: "Return p and run the following steps in parallel :"

@beaufortfrancois beaufortfrancois merged commit 1ea511c into w3c:gh-pages Dec 23, 2019
@beaufortfrancois beaufortfrancois deleted the tag-feedback branch December 23, 2019 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenchris kenchris kenchris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@beaufortfrancois @kenchris