Remove request to adapters to listen to NDEF messages #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenchris
approved these changes
Dec 23, 2019
|
The explicit step was outlined to make clear that if there are multiple NFC adapters, all of them should be used in parallel. The UA should not make a decision which one to use. I think that removing this would be fair but may need to clarify in the premise.
(or something like this). |
zolkis
approved these changes
Dec 24, 2019
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think* we can remove the part where we "make a request to all NFC adapters to listen to NDEF messages" in scan promise as we're already saying that "If there are any NDEFReader instances in activated reader objects then the UA MUST listen to NDEF messages." See https://w3c.github.io/web-nfc/#listening-for-content
Note that we've already checked NFC adapter existence and if NFC connection can be established at that point.
Context: #478 (comment)
Preview | Diff