Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #488: inconsistency in handling Id and MediaType slots #496

Merged
merged 1 commit into from Dec 27, 2019
Merged

Fix #488: inconsistency in handling Id and MediaType slots #496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions index.html
View file
Open in desktop
Expand Up @@ -2044,7 +2044,7 @@ <h2>The <dfn>record type</dfn> string</h2>
<tbody data-link-for="NDEFScanOptions">
<tr>
<td><dfn>[[\Id]]</dfn></td>
<td>An empty <a>string</a>.</td>
<td>`undefined`</td>
<td>
The {{NDEFScanOptions}}.<a>id</a> value.
</td>
Expand All @@ -2058,7 +2058,7 @@ <h2>The <dfn>record type</dfn> string</h2>
</tr>
<tr>
<td><dfn>[[\MediaType]]</dfn></td>
<td>An empty <a>string</a>.</td>
<td>`undefined`</td>
<td>
The {{NDEFScanOptions}}.<a>mediaType</a> value.
</td>
Expand Down Expand Up @@ -3563,7 +3563,7 @@ <h3><dfn>Writing or pushing content</dfn></h3>
Let |matched:boolean| be `false`.
</li>
<li>
If |reader|.<a>[[\Id]]</a> is not empty string and is equal to
If |reader|.<a>[[\Id]]</a> is not `undefined` and is equal to
|record|'s <a href="#dom-ndefrecord-id">id</a>,
[= iteration/continue =].
If it is equal, set |matched| to `true`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Id is undefined, means it matches anything, we'll continue to look at other fields.

Expand All @@ -3576,7 +3576,7 @@ <h3><dfn>Writing or pushing content</dfn></h3>
If it is equal, set |matched| to `true`.
</li>
<li>
If |reader|.<a>[[\MediaType]]</a> is not empty string and is not
If |reader|.<a>[[\MediaType]]</a> is not `undefined` and is not
equal to
|record|'s <a href="#dom-ndefrecord-mediatype">mediaType</a>,
[= iteration/continue =].
Expand Down