Fix #488: inconsistency in handling Id and MediaType slots #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zoltan Kis <zoltan.kis@intel.com>
kenchris
approved these changes
Dec 27, 2019
|
https://w3c.github.io/web-nfc/#dfn-dispatch-nfc-content is using "present" expression for RecordType. |
leonhsl
reviewed
Dec 30, 2019
| @@ -3563,7 +3563,7 @@ <h3><dfn>Writing or pushing content</dfn></h3> | |||
| Let |matched:boolean| be `false`. | |||
| </li> | |||
| <li> | |||
| If |reader|.<a>[[\Id]]</a> is not empty string and is equal to | |||
| If |reader|.<a>[[\Id]]</a> is not `undefined` and is equal to | |||
| |record|'s <a href="#dom-ndefrecord-id">id</a>, | |||
| [= iteration/continue =]. | |||
| If it is equal, set |matched| to `true`. | |||
There was a problem hiding this comment.
If Id is undefined, means it matches anything, we'll continue to look at other fields.
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 3, 2020
And the empty string should just match on empty. The spec change: w3c/web-nfc#496 w3c/web-nfc#498 BUG=520391 Change-Id: Idae55b976a6fbbdd252f6227cbe13ee50d16269c
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 7, 2020
And the empty string should just match on empty. The spec change: w3c/web-nfc#496 w3c/web-nfc#498 BUG=520391 Change-Id: Idae55b976a6fbbdd252f6227cbe13ee50d16269c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986632 Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#728813}
pull bot
pushed a commit
to FreddyZeng/chromium
that referenced
this pull request
Jan 7, 2020
And the empty string should just match on empty. The spec change: w3c/web-nfc#496 w3c/web-nfc#498 BUG=520391 Change-Id: Idae55b976a6fbbdd252f6227cbe13ee50d16269c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986632 Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#728813}
stephenmcgruer
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 8, 2020
#21017) And the empty string should just match on empty. The spec change: w3c/web-nfc#496 w3c/web-nfc#498 BUG=520391 Change-Id: Idae55b976a6fbbdd252f6227cbe13ee50d16269c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986632 Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#728813} Co-authored-by: Han Leon <leon.han@intel.com>
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jan 14, 2020
… undefined means do not filter, a=testonly Automatic update from web-platform-tests [webnfc] NDEFScanOptions#mediaType being undefined means do not filter (#21017) And the empty string should just match on empty. The spec change: w3c/web-nfc#496 w3c/web-nfc#498 BUG=520391 Change-Id: Idae55b976a6fbbdd252f6227cbe13ee50d16269c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986632 Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#728813} Co-authored-by: Han Leon <leon.han@intel.com> -- wpt-commits: 32cb1cf1ba99807715ab5a4184f62e39c47d18f7 wpt-pr: 21017
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 14, 2020
… undefined means do not filter, a=testonly Automatic update from web-platform-tests [webnfc] NDEFScanOptions#mediaType being undefined means do not filter (#21017) And the empty string should just match on empty. The spec change: w3c/web-nfc#496 w3c/web-nfc#498 BUG=520391 Change-Id: Idae55b976a6fbbdd252f6227cbe13ee50d16269c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986632 Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#728813} Co-authored-by: Han Leon <leon.han@intel.com> -- wpt-commits: 32cb1cf1ba99807715ab5a4184f62e39c47d18f7 wpt-pr: 21017
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jan 16, 2020
… undefined means do not filter, a=testonly Automatic update from web-platform-tests [webnfc] NDEFScanOptions#mediaType being undefined means do not filter (#21017) And the empty string should just match on empty. The spec change: w3c/web-nfc#496 w3c/web-nfc#498 BUG=520391 Change-Id: Idae55b976a6fbbdd252f6227cbe13ee50d16269c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986632 Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumikintel.com> Reviewed-by: Daniel Cheng <dchengchromium.org> Commit-Queue: Leon Han <leon.hanintel.com> Cr-Commit-Position: refs/heads/master{#728813} Co-authored-by: Han Leon <leon.hanintel.com> -- wpt-commits: 32cb1cf1ba99807715ab5a4184f62e39c47d18f7 wpt-pr: 21017 UltraBlame original commit: 9d58850dccba1a470c3dc952db0dae26d420d68c
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jan 16, 2020
… undefined means do not filter, a=testonly Automatic update from web-platform-tests [webnfc] NDEFScanOptions#mediaType being undefined means do not filter (#21017) And the empty string should just match on empty. The spec change: w3c/web-nfc#496 w3c/web-nfc#498 BUG=520391 Change-Id: Idae55b976a6fbbdd252f6227cbe13ee50d16269c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986632 Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumikintel.com> Reviewed-by: Daniel Cheng <dchengchromium.org> Commit-Queue: Leon Han <leon.hanintel.com> Cr-Commit-Position: refs/heads/master{#728813} Co-authored-by: Han Leon <leon.hanintel.com> -- wpt-commits: 32cb1cf1ba99807715ab5a4184f62e39c47d18f7 wpt-pr: 21017 UltraBlame original commit: 9d58850dccba1a470c3dc952db0dae26d420d68c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff