New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch: header names are exposed in lowercase and values separated by 0x2C 0x20 #5115
Conversation
Notifying @Manishearth, @caitp, @emilio, @hallvors, @ibelem, @jdm, @jungkees, @kangxu, @mathiasbynens, @ronkorving, @wisniewskit, and @youennf. (Learn how reviewing works.) |
Firefox (nightly channel)Testing web-platform-tests at revision e22f41848f05f6dabffeb726f5fbc58b9882976f All results2 tests ran/XMLHttpRequest/getallresponseheaders-cl.htm
/fetch/api/headers/headers-combine.html
|
Chrome (unstable channel)Testing web-platform-tests at revision e22f41848f05f6dabffeb726f5fbc58b9882976f All results2 tests ran/XMLHttpRequest/getallresponseheaders-cl.htm
/fetch/api/headers/headers-combine.html
|
Instead of just 0x2C, use 0x2C 0x20 somewhat consistently (except where we can't and point it out) as that is what XMLHttpRequest implementations have always done and nobody likes too much change. Tests: web-platform-tests/wpt#5115. Fixes the Fetch part of whatwg/xhr#108 and whatwg/xhr#109.
In particular, setRequestHeader() should use 0x2C 0x20 as separator (not just 0x2C) and get(All)ResponseHeader(s)() should do so too. The latter also always needs to end in 0x0D 0x0A rather than omitting it at the end. This depends on whatwg/fetch#504 landing first. Tests: web-platform-tests/wpt#4641, web-platform-tests/wpt#5008, and web-platform-tests/wpt#5115. Fixes #108 and fixes #109.
See whatwg/fetch#504 and
whatwg/xhr#130.