Fixed config.json not being used in TestEnvironment #10494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build BROKENStarted: 2018-04-16 18:20:29 Failing Jobs
View more information about this build on: |
Added a check in the TestEnvironment load_config so it overrides the default config when present. Closes web-platform-tests#8181
|
@jgraham r? AIUI, this has always been a deliberate decision in wptrunner. That said, I'm happy to change the behaviour here provided we make sure we correctly override everything we depend upon later in |
|
We had a usecase recently when someone wanted to run two wptrunner instances on different builds on the same machine, so some override makes sense to me. |
jgraham
approved these changes
Apr 17, 2018
@jgraham The override doesn't help because we still override the ports used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check in the TestEnvironment load_config so the config.json overrides the
default config when present.
Closes #8181
This change is