Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't wrap HTTPExceptions in FunctionHandler.__call__(). #10505

Merged
merged 1 commit into from Apr 17, 2018
Merged

Don't wrap HTTPExceptions in FunctionHandler.__call__(). #10505

merged 1 commit into from Apr 17, 2018

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Apr 17, 2018 •
edited by wpt-reviewable-bot

Extracted from #6792.

This change is Reviewable

jgraham
jgraham approved these changes Apr 17, 2018
View reviewed changes
Copy link
Contributor

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure I shouldn't be allowed to approve this :)

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Apr 17, 2018

Github won't let me push the button, but I'm pretty sure I should be allowed to, so that cancels out :)

@Ms2ger Ms2ger merged commit 4bf2fa8 into master Apr 17, 2018
@Ms2ger Ms2ger deleted the HTTPException branch April 17, 2018 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgraham jgraham jgraham approved these changes

@gsnedders gsnedders Awaiting requested review from gsnedders

Assignees
No one assigned
Labels
infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ms2ger @jgraham @wpt-pr-bot