Explicitly mark "Timeouts in Tests" as deprecated #11037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
reviewed
May 16, 2018
| @@ -318,14 +318,14 @@ the test result is known. For example: | |||
| }, "Calling document.getElementById with a null argument."); | |||
| ``` | |||
|
|
|||
| ## Timeouts in Tests ## | |||
| ## DEPRECATED Timeouts in Tests ## | |||
There was a problem hiding this comment.
Hmm, reading ahead I now see that this actually isn't about the mechanism we want to remove, this is about setTimeout and step_timeout. I think @jgraham was right that the per-test timeout isn't documented :)
|
Oops, sorry I didn't read carefully enough. Closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #11029