Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use webidl2.js instead of WebIDLParser.js #358

Merged
merged 1 commit into from Oct 4, 2013

Conversation

ayg
Copy link
Contributor

@ayg ayg commented Sep 30, 2013

I'm pretty sure we don't want to use WebIDLParser.js anymore. It's obsolete, right? The files seem to work locally with this change (no exceptions thrown or anything), although I didn't test if it caused any changes in test failures.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/340

This is an external review system which you may optionally use for the code review of your pull request.

tobie added a commit that referenced this pull request Oct 4, 2013
Use webidl2.js instead of WebIDLParser.js
@tobie tobie merged commit d4dbf97 into web-platform-tests:master Oct 4, 2013
@jgraham
Copy link
Contributor

jgraham commented Oct 4, 2013

Please check critic for issues before you merge. This PR is broken at the moment.

@tobie
Copy link
Contributor

tobie commented Oct 4, 2013

This nicely showcases why using both GitHub and an external review system isn't such a great idea.

That said, what do you want me to do about this? And what's broken about this PR?

@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 4, 2013

tobie added a commit to tobie/web-platform-tests that referenced this pull request Oct 4, 2013
…/ayg-use-webidl2"

This reverts commit d4dbf97, reversing
changes made to d2a10f3.
@tobie
Copy link
Contributor

tobie commented Oct 4, 2013

Reverted the merge commit.

This means that should you want to resurrect this pull request, you will need to:

  1. rebase your branch:

    git fetch git@github.com:w3c/web-platform-tests.git
    git rebase FETCH_HEAD submission/ayg-update-dom-interfaces
    
  2. revert the revert I just committed (yeah, I know):

    git revert 13d24a3c501140e56b890281705b36f6ee02c972
    
  3. Make other changes you want to make.

  4. Push your changes back to your fork (which will automatically update this pull request):

    git push git@github.com:ayg/web-platform-tests.git submission/ayg-update-dom-interfaces
    

You'll find a detailed explanation here of the process here.

Ms2ger added a commit that referenced this pull request Oct 4, 2013
Revert "Merge pull request #358 from ayg/submission/ayg-use-webidl2"
@ayg ayg deleted the submission/ayg-use-webidl2 branch April 13, 2016 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants