DOM selector tests wrongly assume '>>' is invalid in selectors #3802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOM selector tests wrongly assume '>>' is invalid in selectors. However, as per Selectors Level 4, this is a valid descendant combinator, identical in behavior to ' ' combinator: - https://drafts.csswg.org/selectors-4/#descendant-combinators
|
Is there consensus to add this seemingly redundant feature? |
|
@Ms2ger I am not very familiar with the Selector specification. What I do know is that the '>>' is part of the specification at the moment and has been shipping in Safari for a while. I think at the very least, we should drop the test that checks that we throw as this hurts browsers like Safari that implement the latest specification. I thought of doing this at first but reviewers usually do not like reducing test coverage. |
zcorpan
approved these changes
Sep 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOM selector tests wrongly assume '>>' is invalid in selectors. However,
as per Selectors Level 4, this is a valid descendant combinator,
identical in behavior to ' ' combinator: