Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for the event handler IDL attribute compilation realm #4089

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add tests for the event handler IDL attribute compilation realm #4089

wants to merge 1 commit into from

Conversation

domenic
Copy link
Member

@domenic domenic commented Oct 26, 2016 •
edited by wpt-pr-bot

See whatwg/html#1956. Not ready to merge until we figure that one out.

@wpt-stability-bot
Copy link

Chrome

Testing revision cd1b12c4693a6f5a97d245fa9258bd1617e8d449
Starting 10 test iterations
All results were stable

All results

/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html

Subtest Results
OK
Event handler IDL attribute compilation errors should be reported to the document's global FAIL
Event handler IDL attributes must return a function from the element's document's realm PASS

@wpt-stability-bot
Copy link

Firefox

Testing revision 41d510a
Starting 10 test iterations
All results were stable

All results

/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html

Subtest Results
TIMEOUT
Event handler IDL attribute compilation errors should be reported to the document's global TIMEOUT
Event handler IDL attributes must return a function from the element's document's realm PASS

@wpt-stability-bot
Copy link

Chrome

Testing revision 41d510a
Starting 10 test iterations
All results were stable

All results

/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html

Subtest Results
TIMEOUT
Event handler IDL attribute compilation errors should be reported to the document's global TIMEOUT
Event handler IDL attributes must return a function from the element's document's realm PASS

@wpt-stability-bot
Copy link

Firefox

Testing revision 2358a06
Starting 10 test iterations
All results were stable

All results

/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html

Subtest Results
TIMEOUT
Event handler IDL attribute compilation errors should be reported to the document's global TIMEOUT
Event handler IDL attributes must return a function from the element's document's realm PASS

@wpt-stability-bot
Copy link

Chrome

Testing revision 2358a06
Starting 10 test iterations
All results were stable

All results

/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html

Subtest Results
TIMEOUT
Event handler IDL attribute compilation errors should be reported to the document's global TIMEOUT
Event handler IDL attributes must return a function from the element's document's realm PASS

@domenic domenic force-pushed the event-handler-attribute-realm branch from 719e19c to 41fb32f Compare October 31, 2016 21:48
@wpt-stability-bot
Copy link

Firefox

Testing revision a21bf48
Starting 10 test iterations
All results were stable

All results

/html/webappapis/timers/compile-errors.html

Subtest Results
OK
setTimeout compilation errors in an active document should fire an error event PASS
setTimeout compilation errors in navigated-away-from documents should not fire any error events PASS

/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html

Subtest Results
OK
Event handler IDL attribute compilation errors in navigated-away-from documents should not fire any error events PASS
Event handler IDL attribute compilation errors in an active document should fire an error event PASS
Event handler IDL attributes must return a function from the element's document's realm PASS

/html/webappapis/animation-frames/callback-exception.html

Subtest Results
OK
requestAnimationFrame errors in navigated-away-from documents should not fire any error events PASS
requestAnimationFrame errors in an active document should fire an error event PASS

@domenic domenic mentioned this pull request Oct 31, 2016
Closed
@wpt-stability-bot
Copy link

Chrome

Testing revision a21bf48
Starting 10 test iterations
All results were stable

All results

/html/webappapis/timers/compile-errors.html

Subtest Results
OK
setTimeout compilation errors in an active document should fire an error event PASS
setTimeout compilation errors in navigated-away-from documents should not fire any error events FAIL

/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html

Subtest Results
OK
Event handler IDL attribute compilation errors in navigated-away-from documents should not fire any error events PASS
Event handler IDL attribute compilation errors in an active document should fire an error event PASS
Event handler IDL attributes must return a function from the element's document's realm PASS

/html/webappapis/animation-frames/callback-exception.html

Subtest Results
OK
requestAnimationFrame errors in navigated-away-from documents should not fire any error events PASS
requestAnimationFrame errors in an active document should fire an error event PASS

@domenic domenic mentioned this pull request Oct 31, 2016
Merged
@domenic domenic mentioned this pull request Oct 31, 2016
Open
@wpt-stability-bot
Copy link

Chrome

Testing revision 6b1b9e5
Starting 10 test iterations
All results were stable

All results

/html/webappapis/timers/compile-errors.html

Subtest Results
OK
setTimeout compilation errors in an active document should fire an error event PASS
setTimeout compilation errors in navigated-away-from documents should not fire any error events FAIL

/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html

Subtest Results
OK
Event handler IDL attribute compilation errors in navigated-away-from documents should not fire any error events PASS
Event handler IDL attribute compilation errors in an active document should fire an error event PASS
Event handler IDL attributes must return a function from the element's document's realm PASS

/html/webappapis/animation-frames/callback-exception.html

Subtest Results
OK
requestAnimationFrame errors in navigated-away-from documents should not fire any error events PASS
requestAnimationFrame errors in an active document should fire an error event PASS

/workers/Worker_ErrorEvent_after_navigation.htm

Subtest Results
OK
Worker error reporting must not work at all if the creator document has been navigated away from PASS
Worker error reporting must work as normal, when no navigation is involved PASS

@wpt-stability-bot
Copy link

Firefox

Testing revision 6b1b9e5
Starting 10 test iterations
All results were stable

All results

/html/webappapis/timers/compile-errors.html

Subtest Results
OK
setTimeout compilation errors in an active document should fire an error event PASS
setTimeout compilation errors in navigated-away-from documents should not fire any error events PASS

/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html

Subtest Results
OK
Event handler IDL attribute compilation errors in navigated-away-from documents should not fire any error events PASS
Event handler IDL attribute compilation errors in an active document should fire an error event PASS
Event handler IDL attributes must return a function from the element's document's realm PASS

/html/webappapis/animation-frames/callback-exception.html

Subtest Results
OK
requestAnimationFrame errors in navigated-away-from documents should not fire any error events PASS
requestAnimationFrame errors in an active document should fire an error event PASS

/workers/Worker_ErrorEvent_after_navigation.htm

Subtest Results
OK
Worker error reporting must not work at all if the creator document has been navigated away from PASS
Worker error reporting must work as normal, when no navigation is involved PASS

zcorpan
zcorpan reviewed Nov 1, 2016
View reviewed changes
workers/support/error-after-some-time.js
}

case "error not expected": {
console.log("got here");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails lint check

@wpt-stability-bot
Copy link

Firefox

Testing revision a87c397
Starting 10 test iterations
All results were stable

All results

/html/webappapis/timers/compile-errors.html

Subtest Results
OK
setTimeout compilation errors in an active document should fire an error event PASS
setTimeout compilation errors in navigated-away-from documents should not fire any error events PASS

/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html

Subtest Results
OK
Event handler IDL attribute compilation errors in navigated-away-from documents should not fire any error events PASS
Event handler IDL attribute compilation errors in an active document should fire an error event PASS
Event handler IDL attributes must return a function from the element's document's realm PASS

/html/webappapis/animation-frames/callback-exception.html

Subtest Results
OK
requestAnimationFrame errors in navigated-away-from documents should not fire any error events PASS
requestAnimationFrame errors in an active document should fire an error event PASS

/workers/Worker_ErrorEvent_after_navigation.htm

Subtest Results
OK
Worker error reporting must not work at all if the creator document has been navigated away from PASS
Worker error reporting must work as normal, when no navigation is involved PASS

@wpt-stability-bot
Copy link

Chrome

Testing revision a87c397
Starting 10 test iterations
All results were stable

All results

/html/webappapis/timers/compile-errors.html

Subtest Results
OK
setTimeout compilation errors in an active document should fire an error event PASS
setTimeout compilation errors in navigated-away-from documents should not fire any error events FAIL

/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html

Subtest Results
OK
Event handler IDL attribute compilation errors in navigated-away-from documents should not fire any error events PASS
Event handler IDL attribute compilation errors in an active document should fire an error event PASS
Event handler IDL attributes must return a function from the element's document's realm PASS

/html/webappapis/animation-frames/callback-exception.html

Subtest Results
OK
requestAnimationFrame errors in navigated-away-from documents should not fire any error events PASS
requestAnimationFrame errors in an active document should fire an error event PASS

/workers/Worker_ErrorEvent_after_navigation.htm

Subtest Results
OK
Worker error reporting must not work at all if the creator document has been navigated away from PASS
Worker error reporting must work as normal, when no navigation is involved PASS

@wpt-stability-bot
Copy link

Firefox

Testing revision a87c397
Starting 10 test iterations
All results were stable

All results

/html/webappapis/timers/compile-errors.html

Subtest Results
OK
setTimeout compilation errors in an active document should fire an error event PASS
setTimeout compilation errors in navigated-away-from documents should not fire any error events PASS

/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html

Subtest Results
OK
Event handler IDL attribute compilation errors in navigated-away-from documents should not fire any error events PASS
Event handler IDL attribute compilation errors in an active document should fire an error event PASS
Event handler IDL attributes must return a function from the element's document's realm PASS

/html/webappapis/animation-frames/callback-exception.html

Subtest Results
OK
requestAnimationFrame errors in navigated-away-from documents should not fire any error events PASS
requestAnimationFrame errors in an active document should fire an error event PASS

/workers/Worker_ErrorEvent_after_navigation.htm

Subtest Results
OK
Worker error reporting must not work at all if the creator document has been navigated away from PASS
Worker error reporting must work as normal, when no navigation is involved PASS

@wpt-stability-bot
Copy link

Chrome

Testing revision a87c397
Starting 10 test iterations
All results were stable

All results

/html/webappapis/timers/compile-errors.html

Subtest Results
OK
setTimeout compilation errors in an active document should fire an error event PASS
setTimeout compilation errors in navigated-away-from documents should not fire any error events FAIL

/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html

Subtest Results
OK
Event handler IDL attribute compilation errors in navigated-away-from documents should not fire any error events PASS
Event handler IDL attribute compilation errors in an active document should fire an error event PASS
Event handler IDL attributes must return a function from the element's document's realm PASS

/html/webappapis/animation-frames/callback-exception.html

Subtest Results
OK
requestAnimationFrame errors in navigated-away-from documents should not fire any error events PASS
requestAnimationFrame errors in an active document should fire an error event PASS

/workers/Worker_ErrorEvent_after_navigation.htm

Subtest Results
OK
Worker error reporting must not work at all if the creator document has been navigated away from PASS
Worker error reporting must work as normal, when no navigation is involved PASS

@domenic domenic force-pushed the event-handler-attribute-realm branch from 5932d75 to 6bcec5c Compare November 3, 2016 23:57
@wpt-stability-bot
Copy link

Firefox

Testing revision 6f58d17
Starting 10 test iterations
All results were stable

All results

/html/webappapis/timers/compile-errors.html

Subtest Results
OK
setTimeout compilation errors in an active document should fire an error event PASS
setTimeout compilation errors in navigated-away-from documents should not fire any error events PASS

/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html

Subtest Results
OK
Event handler IDL attribute compilation errors in navigated-away-from documents should not fire any error events PASS
Event handler IDL attribute compilation errors in an active document should fire an error event PASS
Event handler IDL attributes must return a function from the element's document's realm PASS

/html/webappapis/animation-frames/callback-exception.html

Subtest Results
OK
requestAnimationFrame errors in navigated-away-from documents should not fire any error events PASS
requestAnimationFrame errors in an active document should fire an error event PASS

/workers/Worker_ErrorEvent_after_navigation.htm

Subtest Results
OK
Worker error reporting must not work at all if the creator document has been navigated away from PASS
Worker error reporting must work as normal, when no navigation is involved PASS

@wpt-stability-bot
Copy link

Chrome

Testing revision 6f58d17
Starting 10 test iterations
All results were stable

All results

/html/webappapis/timers/compile-errors.html

Subtest Results
OK
setTimeout compilation errors in an active document should fire an error event PASS
setTimeout compilation errors in navigated-away-from documents should not fire any error events FAIL

/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html

Subtest Results
OK
Event handler IDL attribute compilation errors in navigated-away-from documents should not fire any error events PASS
Event handler IDL attribute compilation errors in an active document should fire an error event PASS
Event handler IDL attributes must return a function from the element's document's realm PASS

/html/webappapis/animation-frames/callback-exception.html

Subtest Results
OK
requestAnimationFrame errors in navigated-away-from documents should not fire any error events PASS
requestAnimationFrame errors in an active document should fire an error event PASS

/workers/Worker_ErrorEvent_after_navigation.htm

Subtest Results
OK
Worker error reporting must not work at all if the creator document has been navigated away from PASS
Worker error reporting must work as normal, when no navigation is involved PASS

zcorpan
zcorpan reviewed Nov 8, 2016
View reviewed changes
html/webappapis/animation-frames/callback-exception.html
});

// The test passes if no error events have been fired within this time.
setTimeout(t.step_func_done(), 10);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're supposed to use t.step_timeout(() => { t.done(); }, 10); so certain environments that need longer timeouts can do that. But also 10ms is too short for stable results; I believe @jgraham has recommended no less than 2000ms.

@wpt-stability-bot
Copy link

Firefox

Testing revision d86386b
Starting 10 test iterations
All results were stable

All results

/html/webappapis/timers/compile-errors.html

Subtest Results
OK
setTimeout compilation errors in an active document should fire an error event PASS
setTimeout compilation errors in navigated-away-from documents should not fire any error events PASS

/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html

Subtest Results
OK
Event handler IDL attribute compilation errors in navigated-away-from documents should not fire any error events PASS
Event handler IDL attribute compilation errors in an active document should fire an error event PASS
Event handler IDL attributes must return a function from the element's document's realm PASS

/html/webappapis/animation-frames/callback-exception.html

Subtest Results
OK
requestAnimationFrame errors in navigated-away-from documents should not fire any error events PASS
requestAnimationFrame errors in an active document should fire an error event PASS

/workers/Worker_ErrorEvent_after_navigation.htm

Subtest Results
OK
Worker error reporting must not work at all if the creator document has been navigated away from PASS
Worker error reporting must work as normal, when no navigation is involved PASS

@wpt-stability-bot
Copy link

wpt-stability-bot commented Nov 11, 2016 •
edited by zcorpan

Testing revision d86386b in Chrome

All results were stable

/html/webappapis/timers/compile-errors.html

Subtest Results
OK
setTimeout compilation errors in an active document should fire an error event PASS
setTimeout compilation errors in navigated-away-from documents should not fire any error events FAIL

/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html

Subtest Results
OK
Event handler IDL attribute compilation errors in navigated-away-from documents should not fire any error events PASS
Event handler IDL attribute compilation errors in an active document should fire an error event PASS
Event handler IDL attributes must return a function from the element's document's realm PASS

/html/webappapis/animation-frames/callback-exception.html

Subtest Results
OK
requestAnimationFrame errors in navigated-away-from documents should not fire any error events PASS
requestAnimationFrame errors in an active document should fire an error event PASS

/workers/Worker_ErrorEvent_after_navigation.htm

Subtest Results
OK
Worker error reporting must not work at all if the creator document has been navigated away from PASS
Worker error reporting must work as normal, when no navigation is involved PASS

(Comment edited by @zcorpan to experiment with <details>)

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 14, 2016

Is there a particular reason to change the tools submodule?

@domenic
Copy link
Member Author

domenic commented Nov 14, 2016

Sigh, no, just some branch-switching confusion. Will fix.

@domenic
Add tests for the event handler and error event realms
d7e3da7 
See whatwg/html#1956. In particular, this tests that:

- Event handler IDL attributes are compiled in the right realm
- Event handler IDL attribute compilation, setTimeout, and requestAnimationFrame do not "report the exception" for inactive documents
@domenic domenic force-pushed the event-handler-attribute-realm branch from f2699d1 to d7e3da7 Compare November 14, 2016 22:14
@wpt-stability-bot
Copy link

Firefox

Testing revision 7847657
Starting 10 test iterations
All results were stable

All results

/html/webappapis/timers/compile-errors.html

Subtest Results
OK
setTimeout compilation errors in an active document should fire an error event PASS
setTimeout compilation errors in navigated-away-from documents should not fire any error events PASS

/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html

Subtest Results
OK
Event handler IDL attribute compilation errors in navigated-away-from documents should not fire any error events PASS
Event handler IDL attribute compilation errors in an active document should fire an error event PASS
Event handler IDL attributes must return a function from the element's document's realm PASS

/html/webappapis/animation-frames/callback-exception.html

Subtest Results
OK
requestAnimationFrame errors in navigated-away-from documents should not fire any error events PASS
requestAnimationFrame errors in an active document should fire an error event PASS

/workers/Worker_ErrorEvent_after_navigation.htm

Subtest Results
OK
Worker error reporting must not work at all if the creator document has been navigated away from PASS
Worker error reporting must work as normal, when no navigation is involved PASS

@wpt-stability-bot
Copy link

Chrome

Testing revision 7847657
Starting 10 test iterations
All results were stable

All results

/html/webappapis/timers/compile-errors.html

Subtest Results
OK
setTimeout compilation errors in an active document should fire an error event PASS
setTimeout compilation errors in navigated-away-from documents should not fire any error events FAIL

/html/webappapis/scripting/events/event-handler-idl-attribute-realm.html

Subtest Results
OK
Event handler IDL attribute compilation errors in navigated-away-from documents should not fire any error events PASS
Event handler IDL attribute compilation errors in an active document should fire an error event PASS
Event handler IDL attributes must return a function from the element's document's realm PASS

/html/webappapis/animation-frames/callback-exception.html

Subtest Results
OK
requestAnimationFrame errors in navigated-away-from documents should not fire any error events PASS
requestAnimationFrame errors in an active document should fire an error event PASS

/workers/Worker_ErrorEvent_after_navigation.htm

Subtest Results
OK
Worker error reporting must not work at all if the creator document has been navigated away from PASS
Worker error reporting must work as normal, when no navigation is involved PASS

@gsnedders gsnedders closed this Jan 24, 2020
@gsnedders gsnedders deleted the event-handler-attribute-realm branch January 24, 2020 18:06
@gsnedders gsnedders restored the event-handler-attribute-realm branch January 24, 2020 18:42
@Hexcles Hexcles reopened this Jan 24, 2020
@wpt-pr-bot wpt-pr-bot requested a deployment to wpt-preview-4089 July 15, 2020 07:16 Abandoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcorpan zcorpan zcorpan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
do not merge yet html workers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@domenic @wpt-stability-bot @Ms2ger @zcorpan @gsnedders @marcoscaceres @Hexcles @wpt-pr-bot