Add "0xCA <=> U+05BA" mapping to windows-1255 (spec change) #4090
Conversation
|
Reviewers for this pull request are: @inexorabletash and @sideshowbarker. |
|
Also submitted independently in https://bugzilla.mozilla.org/show_bug.cgi?id=1312384 |
|
@jgraham which should we land with this kind of conflict? |
|
I'm confused. wpt is getting an automatic push from hg.mozilla.org ? |
Yes - isn't that awesome? (Hopefully coming soon to chromium/blink, too.) |
I see. Thank you. In that case, feel free to close this one if the automatic push from hg.mozilla.org is gonna be done soon (say, in a couple of days). |
|
I can start a new one today. |
|
Sorry about the conflict @jungshik, hope we don't get too many of these. 😊 |
|
No problem, @annevk BTW, was the change (mozilla's : identical to mine) landed? I don't see it in the tree. |
|
@jgraham can best answer that. Syncing is manual still. |
|
Gee. I thought it's automatic and pretty frequent (if not daily). Given that it's neither, just merging this world have been quicker. |
|
Agreed, I went ahead and did so, given that I can't seem to chat with @jgraham. |
See https://codereview.chromium.org/2442923002 for actual changes. Fix base_unittests:NumberFormattingTest.FormatPercent per new percent formats for Arabic and Persian in CLDR 30/ICU 58. Adjust IsIDNComponentSafe() to keep the current behavior (therefore, no changes in tests) with ICU 58.1 changes in uspoof API. Rebaselined a few layout tests (no substantial changes) and changed one test. fast/text/midword-break-before-surrogate-pair: expectation was wrong about the line breaking behavior of regional indiactors. The following two wpt tests are directly changed in our tree with an upstream pull request made for the change: web-platform-tests/wpt#4090 imported/wpt/encoding/textdecoder-fatal-single-byte imported/wpt/encoding/textdecoder-labels BUG=637001 TEST=Layout tests, all unittests, browser tests Review-Url: https://codereview.chromium.org/2447513002 Cr-Original-Commit-Position: refs/heads/master@{#429312} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: b2b928ac0d2e7caabffd9a10b94e71ef534b206a
In whatwg/encoding#73, the encoding spec was changed to add "0xCA<=>U+05BA" mapping to
windows-1255.
@annevk , can you review? Thanks