Add tests for some of the assumptions of the test suite #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ms2ger
approved these changes
Jan 26, 2017
assumptions/html-elements.html
Outdated
| }, "ul > li is display: block"); | ||
|
|
||
| test(function() { | ||
| var ol_li = document.getElementsByTagName("li")[0]; |
There was a problem hiding this comment.
This one's ul > li, not ol > li
assumptions/html-elements.html
Outdated
|
|
||
| for (var i = 0; i < a_styles.length; i++) { | ||
| var property = a_styles[i]; | ||
| assert_equals(property, b_styles[i], "Same property on #a and #b"); |
There was a problem hiding this comment.
I'm not quite sure if all of this is guaranteed, but I'm not going to worry about it until someone complains.
There was a problem hiding this comment.
Like, why aren't you sure if it's all guaranteed?
gsnedders
force-pushed
the
test-assumptions
branch
from
430f244
to
24f08e8
Compare
Chrome (unstable channel)Testing web-platform-tests at revision d9d5f21 All results/assumptions/initial-color.html
/assumptions/min-font-size.html
/assumptions/html-elements.html
/assumptions/medium-font-size.html
/assumptions/canvas-background.html
|
Firefox (nightly channel)Testing web-platform-tests at revision d9d5f21 All results/assumptions/initial-color.html
/assumptions/min-font-size.html
/assumptions/html-elements.html
/assumptions/medium-font-size.html
/assumptions/canvas-background.html
|
gsnedders
force-pushed
the
test-assumptions
branch
2 times, most recently
from
dba11f5
to
6e54ae6
Compare
|
w3c-test:mirror |
This starts to resolve web-platform-tests#3827
gsnedders
force-pushed
the
test-assumptions
branch
from
6e54ae6
to
4aa5ab3
Compare
|
@Ms2ger r? |
Ms2ger
requested changes
Feb 8, 2017
assumptions/html-elements.html
Outdated
|
|
||
| test(function() { | ||
| assert_in_array(window.getComputedStyle(document.querySelector("div.c")).backgroundColor, | ||
| ["rgba(0, 0, 0, 0)", "transparent"]); |
assumptions/html-elements.html
Outdated
| var a_styles = window.getComputedStyle(a); | ||
| var b_styles = window.getComputedStyle(b); | ||
|
|
||
| assert_equals(a_styles.length, b_styles.length, "Same properties on both #a and #b"); |
There was a problem hiding this comment.
Going to fix the #a references?
There was a problem hiding this comment.
I thought I'd pushed that fix.
assumptions/html-elements.html
Outdated
| var ul_li = document.querySelector("ul > li"); | ||
| var styles = window.getComputedStyle(ul_li); | ||
| assert_equals(styles["display"], "list-item"); | ||
| }, "ul > li is display: block"); |
| }, "tr is display: table-row"); | ||
|
|
||
| test(function() { | ||
| var td = document.getElementsByTagName("td")[0]; |
There was a problem hiding this comment.
This hasn't historically been a documented assumption, hence it wasn't included here. (Nor colgroup, etc.)
| @@ -0,0 +1,9 @@ | |||
| <!doctype html> | |||
| <title>Check 1px and 2px font-sizes are different</title> | |||
| <link rel="mismatch" href="min-font-size-ref.html"> | |||
There was a problem hiding this comment.
Could use -notref. Not sure what our policy is on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts to resolve #3827
This change is