Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of requests in header-values-normalize #4583

Merged
merged 2 commits into from Jan 27, 2017

Conversation

annevk
Copy link
Member

@annevk annevk commented Jan 20, 2017

See discussion in #4525.

@wpt-pr-bot
Copy link
Collaborator

Notifying @jdm and @youennf. (Learn how reviewing works.)

if(fail) {
promise_rejects(t, new TypeError(), fetch("about:blank", { headers: {"val1": val1} }))
promise_rejects(t, new TypeError(), fetch("about:blank", { headers: {"val2": val2} }))
return promise_rejects(t, new TypeError(), fetch("about:blank", { headers: {"val3": val3} }))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the above three lines being the correct way to do this. I asked in #whatwg but nobody was around to answer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want that to be return Promise.all([promise_rejects(...), promise_rejects(...), promise_rejects(...)])?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that work? I cannot really find any documentation about how this is supposed to work. @jgraham?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the callback to promise_test needs to return a single promise that encompasses all asynchronous behaviour. Promise.all is what you want here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

@wpt-stability-bot
Copy link

wpt-stability-bot commented Jan 20, 2017

Firefox (nightly channel)

Testing web-platform-tests at revision 6180f11
Using browser at version BuildID 20170118211214; SourceStamp a5253dce8b67c2248d7b92ef664a6dd6664e7609
Starting 10 test iterations
All results were stable

All results

/fetch/api/headers/header-values-normalize.html
Subtest Results
OK
fetch() with value %13 PASS
XMLHttpRequest with value %16 PASS
XMLHttpRequest with value %17 PASS
fetch() with value %1C PASS
fetch() with value %16 PASS
XMLHttpRequest with value %1C PASS
XMLHttpRequest with value %1B PASS
fetch() with value %1A PASS
fetch() with value %1B PASS
fetch() with value %17 PASS
fetch() with value %1D PASS
fetch() with value %1E PASS
XMLHttpRequest with value %1D PASS
XMLHttpRequest with value %1E PASS
XMLHttpRequest with value %09 PASS
XMLHttpRequest with value %08 PASS
XMLHttpRequest with value %1A PASS
fetch() with value %20 PASS
XMLHttpRequest with value %20 PASS
XMLHttpRequest with value %01 PASS
XMLHttpRequest with value %00 PASS
XMLHttpRequest with value %03 PASS
XMLHttpRequest with value %02 PASS
XMLHttpRequest with value %05 PASS
XMLHttpRequest with value %04 PASS
XMLHttpRequest with value %07 PASS
XMLHttpRequest with value %06 PASS
fetch() with value %07 PASS
fetch() with value %06 PASS
fetch() with value %05 PASS
fetch() with value %04 PASS
fetch() with value %03 PASS
fetch() with value %02 PASS
fetch() with value %01 PASS
fetch() with value %00 PASS
XMLHttpRequest with value %1F PASS
fetch() with value %09 PASS
fetch() with value %08 PASS
fetch() with value %0F PASS
fetch() with value %0E PASS
fetch() with value %0D FAIL
fetch() with value %0A FAIL
XMLHttpRequest with value %0A PASS
XMLHttpRequest with value %0E PASS
XMLHttpRequest with value %0D PASS
XMLHttpRequest with value %0F PASS
fetch() with value %18 PASS
fetch() with value %19 PASS
XMLHttpRequest with value %18 PASS
XMLHttpRequest with value %19 PASS
fetch() with value %10 PASS
fetch() with value %11 PASS
XMLHttpRequest with value %10 PASS
XMLHttpRequest with value %11 PASS
fetch() with value %14 PASS
fetch() with value %15 PASS
XMLHttpRequest with value %14 PASS
XMLHttpRequest with value %15 PASS
XMLHttpRequest with value %12 PASS
fetch() with value %1F PASS
XMLHttpRequest with value %13 PASS
fetch() with value %12 PASS

@wpt-stability-bot
Copy link

wpt-stability-bot commented Jan 20, 2017

Chrome (unstable channel)

Testing web-platform-tests at revision 6180f11
Using browser at version 55.0.2883.75
Starting 10 test iterations
All results were stable

All results

/fetch/api/headers/header-values-normalize.html
Subtest Results
OK
fetch() with value %13 PASS
XMLHttpRequest with value %16 PASS
XMLHttpRequest with value %17 PASS
fetch() with value %1C PASS
fetch() with value %16 PASS
XMLHttpRequest with value %1C PASS
XMLHttpRequest with value %1B PASS
fetch() with value %1A PASS
fetch() with value %1B PASS
fetch() with value %17 PASS
fetch() with value %1D PASS
fetch() with value %1E PASS
XMLHttpRequest with value %1D PASS
XMLHttpRequest with value %1E PASS
XMLHttpRequest with value %09 PASS
XMLHttpRequest with value %08 PASS
XMLHttpRequest with value %1A PASS
fetch() with value %20 PASS
XMLHttpRequest with value %20 PASS
XMLHttpRequest with value %01 PASS
XMLHttpRequest with value %00 PASS
XMLHttpRequest with value %03 PASS
XMLHttpRequest with value %02 PASS
XMLHttpRequest with value %05 PASS
XMLHttpRequest with value %04 PASS
XMLHttpRequest with value %07 PASS
XMLHttpRequest with value %06 PASS
fetch() with value %07 PASS
fetch() with value %06 PASS
fetch() with value %05 PASS
fetch() with value %04 PASS
fetch() with value %03 PASS
fetch() with value %02 PASS
fetch() with value %01 PASS
fetch() with value %00 PASS
XMLHttpRequest with value %1F PASS
fetch() with value %09 PASS
fetch() with value %08 PASS
fetch() with value %0F PASS
fetch() with value %0E PASS
fetch() with value %0D FAIL
fetch() with value %0A FAIL
XMLHttpRequest with value %0A FAIL
XMLHttpRequest with value %0E PASS
XMLHttpRequest with value %0D FAIL
XMLHttpRequest with value %0F PASS
fetch() with value %18 PASS
fetch() with value %19 PASS
XMLHttpRequest with value %18 PASS
XMLHttpRequest with value %19 PASS
fetch() with value %10 PASS
fetch() with value %11 PASS
XMLHttpRequest with value %10 PASS
XMLHttpRequest with value %11 PASS
fetch() with value %14 PASS
fetch() with value %15 PASS
XMLHttpRequest with value %14 PASS
XMLHttpRequest with value %15 PASS
XMLHttpRequest with value %12 PASS
fetch() with value %1F PASS
XMLHttpRequest with value %13 PASS
fetch() with value %12 PASS

@annevk
Copy link
Member Author

annevk commented Jan 27, 2017

@ricea does this look good now? @jdm?

@jdm jdm merged commit fc2dc86 into master Jan 27, 2017
@jdm
Copy link
Contributor

jdm commented Jan 27, 2017

Yep!

@annevk annevk deleted the annevk/header-value-normalize branch January 27, 2017 08:01
@ricea
Copy link
Contributor

ricea commented Jan 29, 2017

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants