Adjust XHR CORS test to allow custom Content-Type

[sideshowbarker]

No description provided.

[wpt-pr-bot]

Notifying @Manishearth, @Ms2ger, @caitp, @emilio, @hallvors, @ibelem, @jdm, @jungkees, @kangxu, @mathiasbynens, and @ronkorving. (Learn how reviewing works.)

These tests will be available shortly on w3c-test.org.

• XMLHttpRequest/resources/

[w3c-bots]

Chrome (unstable channel)

Testing web-platform-tests at revision b18cb2f
Using browser at version 58.0.3004.3 dev
Starting 10 test iterations
All results were stable

All results

/XMLHttpRequest/timeout-cors-async.htm

Subtest	Results
	OK
XMLHttpRequest: timeout event and cross-origin request	PASS

/XMLHttpRequest/event-upload-progress-crossorigin.htm

Subtest	Results
	OK
XMLHttpRequest: upload progress event for cross-origin requests	PASS

/XMLHttpRequest/send-redirect-to-cors.htm

Subtest	Results
	OK
XMLHttpRequest: send() - Redirect to CORS-enabled resource (307 post with null)	PASS
XMLHttpRequest: send() - Redirect to CORS-enabled resource (301)	PASS
XMLHttpRequest: send() - Redirect to CORS-enabled resource (303)	PASS
XMLHttpRequest: send() - Redirect to CORS-enabled resource (302)	PASS
XMLHttpRequest: send() - Redirect to CORS-enabled resource (307 post with string)	PASS
XMLHttpRequest: send() - Redirect to CORS-enabled resource (307)	PASS
XMLHttpRequest: send() - Redirect to CORS-enabled resource (307 post with typed array)	PASS

[w3c-bots]

Firefox (nightly channel)

Testing web-platform-tests at revision b18cb2f
Using browser at version BuildID 20170123125947; SourceStamp 36486fdc3813ef7943ae5b07b4128866d1938a6c
Starting 10 test iterations
All results were stable

All results

/XMLHttpRequest/timeout-cors-async.htm

Subtest	Results
	OK
XMLHttpRequest: timeout event and cross-origin request	PASS

/XMLHttpRequest/event-upload-progress-crossorigin.htm

Subtest	Results
	OK
XMLHttpRequest: upload progress event for cross-origin requests	PASS

/XMLHttpRequest/send-redirect-to-cors.htm

Subtest	Results
	OK
XMLHttpRequest: send() - Redirect to CORS-enabled resource (307 post with null)	PASS
XMLHttpRequest: send() - Redirect to CORS-enabled resource (301)	PASS
XMLHttpRequest: send() - Redirect to CORS-enabled resource (303)	PASS
XMLHttpRequest: send() - Redirect to CORS-enabled resource (302)	PASS
XMLHttpRequest: send() - Redirect to CORS-enabled resource (307 post with string)	PASS
XMLHttpRequest: send() - Redirect to CORS-enabled resource (307)	PASS
XMLHttpRequest: send() - Redirect to CORS-enabled resource (307 post with typed array)	PASS

[annevk]

Can you explain what you are making this change for? Hard to tell without corresponding test.

[sideshowbarker]

See https://github.com/w3c/web-platform-tests/blob/master/XMLHttpRequest/send-redirect-to-cors.htm#L53

As far as I can see, those tests are failing in Blink and WebKit due to the Access-Control-Allow-Headers response header generated from XMLHttpRequest/resources/corsenabled.py not including Content-Type. (Why they pass in Gecko anyway without this change I don’t understand.)

[annevk]

I think what we should do instead is invert the pass condition there and file a bug against Gecko as Gecko violates CORS there.

[annevk]

Because https://fetch.spec.whatwg.org/#cors-preflight-fetch-0 step 6.9 only allows it to be omitted if its safelisted, which that particular value is not.

[annevk]

Closing this in favor of my PR to solve this issue, which ends up highlighting the problem in Firefox. Two tests still fail in WebKit but that seems like a bug.