Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reftest-wait in web-platform-tests #5057

Merged
merged 2 commits into from Mar 7, 2017

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 7, 2017

The web-platform-tests (wpt) suite allows tests to control when the screenshot is
taken for reftests, based on the presence (and then absence) of a 'reftest-wait'
class on the root element.

To support this mechanism a JavaScript shim is inserted into wpt tests, which uses
existing TestRunner methods (waitUntilDone, notifyDone), combined with a
MutationObserver on the root element.

BUG=698256

Review-Url: https://codereview.chromium.org/2729863004
Cr-Commit-Position: refs/heads/master@{#455009}


This change is Reviewable

The web-platform-tests (wpt) suite allows tests to control when the screenshot is
taken for reftests, based on the presence (and then absence) of a 'reftest-wait'
class on the root element.

To support this mechanism a JavaScript shim is inserted into wpt tests, which uses
existing TestRunner methods (waitUntilDone, notifyDone), combined with a
MutationObserver on the root element.

BUG=698256

Review-Url: https://codereview.chromium.org/2729863004
Cr-Commit-Position: refs/heads/master@{#455009}
@w3c-bots
Copy link

w3c-bots commented Mar 7, 2017

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision 1ca163917881124eec8e7a6ac8ea78724e53e6a6
Using browser at version BuildID 20170306110339; SourceStamp 966464a68a2cb3ca1125808e34abb5c1d34e3797
Starting 10 test iterations
All results were stable

All results

1 test ran
/infrastructure/reftest-wait.html
Subtest Results Messages
TIMEOUT

@w3c-bots
Copy link

w3c-bots commented Mar 7, 2017

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision 1ca163917881124eec8e7a6ac8ea78724e53e6a6
Using browser at version 58.0.3026.3 dev
Starting 10 test iterations
All results were stable

All results

1 test ran
/infrastructure/reftest-wait.html
Subtest Results Messages
TIMEOUT

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 87f3b44 into master Mar 7, 2017
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-try branch March 7, 2017 01:38
@foolip
Copy link
Member

foolip commented Mar 7, 2017

@Ms2ger, you were the one who added the only test in infrastructure/, can you just vet that you approve of adding this kind of test here? Seems useful since we in fact didn't support this in Chromium before, and at least I never noticed.

@foolip
Copy link
Member

foolip commented Mar 7, 2017

/cc @qyearsley @jeffcarp, who pointed this out to me elsewhere

@jdm
Copy link
Contributor

jdm commented Mar 7, 2017

Basic feature tests like this seem totally reasonable to me.

@foolip foolip added the infra label Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants