Add idlharness.js test for Fullscreen #5903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a whole other spec's IDL as untested isn't commonly done, so this ran into multiple problems in idlharness.js, which were fixed: * test_primary_interface_of and test_interface_of were missing untested checks * the readonly (no setter) checks didn't know about [LenientSetter] There's still no coverage for [LenientSetter] actually working.
Firefox (nightly)Testing web-platform-tests at revision 1bca831 All results1 test ran/fullscreen/interfaces.html
|
Chrome (unstable)Testing web-platform-tests at revision 1bca831 All results1 test ran/fullscreen/interfaces.html
|
This was referenced May 12, 2017
foolip
commented
May 12, 2017
| @@ -1684,6 +1691,9 @@ IdlInterface.prototype.test_interface_of = function(desc, obj, exception, expect | |||
| for (var i = 0; i < this.members.length; i++) | |||
| { | |||
| var member = this.members[i]; | |||
| if (member.untested) { | |||
There was a problem hiding this comment.
Yes, the style in this file is inconsistent, so I tried to be locally consistent.
|
I'm not quite familiar with IDL tests... so probably @annevk should review this. |
|
I don't know the IDL harness code. I was actually asking on IRC who can so I'm surprised @jgraham assigns me! Having said that, if this runs I'd be okay with landing it... |
|
@annevk says not to expect speedy responses from @Ms2ger or @ayg, so I'll just go ahead and merge this. It will affect other tests using testharness.js, but should in those cases too only be skipping tests that should have been skipped all along. I checked XMLHttpRequest/interfaces.html and html/dom/interfaces.html before and after and as expected there's a reduction in the number of tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a whole other spec's IDL as untested isn't commonly done, so this
ran into multiple problems in idlharness.js, which were fixed:
There's still no coverage for [LenientSetter] actually working.
This change is