<applet> is hardly a thing now #6684
Conversation
document.applets (which always return an empty collection) and a mention in the HTML parser, but that's it.
wpt-pr-bot
requested review from
ayg,
hillbrad,
jdm,
jgraham,
zcorpan and
zqzhang
Build PASSEDStarted: 2017-08-21 15:10:27 View more information about this build on: |
Sauce (safari) |
Chrome (unstable) |
Sauce (MicrosoftEdge) |
There was a problem hiding this comment.
It seems like there could be some useful negative tests created here. E.g. that there is no CSP violation generated; that applet doesn't show up in the window named properties (by name or ID); that they don't have priority over divs in the document.* properties.
I think we should also introduce a -historical.html test for everything in the OP of whatwg/html#1399, perhaps consolidated into one file. Including user agent stylesheet stuff.
I know this is more work, but I do think especially given all the extra places we removed it from, having a nice set of tests for implementers will help.
|
Good call, found a bug in Chrome: https://bugs.chromium.org/p/chromium/issues/detail?id=757434. |
This removes support for the applet element from: * document.all[name] * document[name] * window[name] Furthermore: * document.applets now returns an empty array * Removed handling for applet elements in <iframe sandbox> * Removed rendering rules for applet elements * Removed the element itself and HTMLAppletElement * Applet elements now use HTMLUnknownElement The HTML parser is intentionally not changed. Tests: web-platform-tests/wpt#6684. Fixes #454.
| }, "window cannot find applet") | ||
|
|
||
| test(() => { | ||
| assert_equals(self.getComputedStyle(document.getElementsByTagName("applet")[0], "").cssFloat, "none"); |
There was a problem hiding this comment.
Might be nice to test vertical-align too.
|
Is there any reason this isn't merged? |
Build PASSEDStarted: 2017-08-21 15:10:27 View more information about this build on: |
|
I'm not sure. |
|
I mean, there's still some outstanding missing coverage per my last review. I guess I'll file an issue. |
|
Ah yeah, that's probably why. But it seems better to have this checked in. |
This removes support for the applet element from: * document.all[name] * document[name] * window[name] Furthermore: * document.applets now returns an empty array * Removed handling for applet elements in <iframe sandbox> * Removed rendering rules for applet elements * Removed the element itself and HTMLAppletElement * Applet elements now use HTMLUnknownElement The HTML parser is intentionally not changed. Tests: web-platform-tests/wpt#6684. Fixes whatwg#454.
document.applets (which always return an empty collection) and a mention in the HTML parser, but that's it.
This is for whatwg/html#1399 and https://bugzilla.mozilla.org/show_bug.cgi?id=1386008.