Update and trim down scripts in /2dcontext/tools #7219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build PASSEDStarted: 2017-09-01 11:23:14 View more information about this build on: |
Remove --standalone option and mochitest business, but generate annotated-spec.html (not checked in), and fix various bugs. Update specextract.py and fetch a new copy of the spec. The "text" snippets in spec.yaml should be updated to match against the current spec, which can be worked on as followups.
zcorpan
force-pushed
the
zcorpan/2dcontext-specextract
branch
from
68603d7
to
c9c39eb
Compare
|
Checks passed; ready for review. |
gsnedders
reviewed
Sep 1, 2017
| @@ -1,50 +1,74 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?><html xml:lang="en-US-x-hixie" xmlns="http://www.w3.org/1999/xhtml"><head><title>HTML Standard</title><link href="http://www.whatwg.org/style/specification" rel="stylesheet"/><link href="http://www.whatwg.org/images/icon" rel="icon"/><style> | |||
There was a problem hiding this comment.
I presume we can't just use a git submodule here rather than checking in a large part of the HTML spec?
There was a problem hiding this comment.
I dunno, I thought we generally try to avoid submodules? Also spec.yaml has text that's supposed to sync up with the spec, it seems clearer for reviewers if it's checked in.
There was a problem hiding this comment.
We have plenty of other submodules used for such things; I thought it was required submodules that people didn't like. But yeah, I don't really care. shrugs
gsnedders
approved these changes
Sep 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove --standalone option and mochitest business, but generate
annotated-spec.html (not checked in), and fix various bugs.
Update specextract.py and fetch a new copy of the spec.
The "text" snippets in spec.yaml should be updated to match against
the current spec, which can be worked on as followups.