Set up check_stability logging at root level #7768
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebjerring
force-pushed
the
basic-logging
branch
from
978486b
to
6b00acb
Compare
Build PASSEDStarted: 2017-10-19 15:11:31 View more information about this build on: |
lukebjerring
commented
Oct 13, 2017
| handler = logging.StreamHandler(sys.stdout) | ||
| formatter = logging.Formatter(logging.BASIC_FORMAT, None) | ||
| handler.setFormatter(formatter) | ||
| logger.addHandler(handler) | ||
| logger.setLevel(logging.DEBUG) | ||
| logger.propagate = False |
There was a problem hiding this comment.
Unsure about this - Added to avoid dup'd messages if someone sets up root-level debugging elsewhere
lukebjerring
commented
Oct 16, 2017
| @@ -10,7 +10,7 @@ | |||
| here = os.path.dirname(__file__) | |||
| wpt_root = os.path.abspath(os.path.join(here, os.pardir, os.pardir)) | |||
|
|
|||
| logger = logging.getLogger() | |||
| logger = logging.getLogger(wpt_root) | |||
There was a problem hiding this comment.
Note that in testfiles (where the lack of root-logging setup was the issue) and check_stability are both changed to wpt_root dir logging.
lukebjerring
force-pushed
the
basic-logging
branch
2 times, most recently
from
fc67efa
to
ae9cbe9
Compare
lukebjerring
force-pushed
the
basic-logging
branch
from
ae9cbe9
to
037e88b
Compare
|
So, I might have fixed this in the wpt tool with another change that I made recently. Can you verify that the problem still exists on current master? |
|
Yep, unable to repro the problem anymore - closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the command
git fetch https://github.com/w3c/web-platform-tests.git master:masterfails (because of local branch state), logging is attempted (with the default/root logger), which is not set up. This causes the output to be:instead of something like
cc/ @jgraham
This change is