new test files from TestTWF #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,22 @@ | |||
| <!DOCTYPE HTML> | |||
| <html> | |||
| <body onload="load_test_attr.done()"> | |||
There was a problem hiding this comment.
Bogus onload :-)
Also, you need metadata: your author info, plus a meta help to the relevant place in the spec for this one.
|
Hey Dan Druta! Thanks a lot for the tests, they seem to be good themselves, but I have raised a whole lot of style issues. It's cool to get some tests on document.all :-) (so no secret webappsec tests today as well, no? :-) ) |
|
Did you intend to push your fixes? I don't see them. |
|
Pushed them now. Sorry |
|
GitHub reviews are a bit hard to get an overview over. Some final points:
Removing the html and body tags is not necessary, but if they're there they should at least be placed at their rightful place, it's easier and nicer to just drop them. |
Merged
jgraham
added a commit
that referenced
this pull request
Apr 21, 2017
Return the result from ServoTestharnessExecutor.do_test.
gsnedders
added a commit
to gsnedders/web-platform-tests
that referenced
this pull request
Nov 3, 2017
8a7ff70664 chore(package): bump version number to 8.1.0 f26e320e49 feat: always add rhs property (web-platform-tests#110) 8fc7b2ea19 docs(README): Removed redundant sections 649e457b78 chore(CHANGELOG): regenerate c1af872481 chore(package): bump version number to 8.0.1 407aaefc9f Remove m postfix from all_ws() (web-platform-tests#108) 8f7c37ea23 chore(package): bump version number to 8.0 6f86663dbc feat: support mixins + includes statements (web-platform-tests#105) d1f2352275 docs(README): fix typo 0ecc48607c BREAKING CHANGE: drop creator support (web-platform-tests#101) 4f1aab4e77 chore: drop Node 6 support (web-platform-tests#102) af08834028 style: Normalize some whitespace to pass wpt's lint (web-platform-tests#99) e938ba5eea chore(package): bump version number to 7.0 cb85ff1a02 BREAKING CHANGE: argument type should be a string 101d9067ae chore(package): bump version number 67af674490 docs(README): extended attribute type b4013a14cc feat: give extended attributes a type d15fcb28a9 Yet another innocuous change for tests dd01a2ba48 Another innocuous change for tests 706d6251d5 Innocuous change to trigger a cvs.w3.org refresh 31be15dd81 chore(package): update jsondiffpatch ca6c08ccd8 chore(CHANGELOG): regenerate 8ce266fc02 Use ES2015 syntax for tests (web-platform-tests#88) 7ffef282e1 chore(package): bump version number 9d2071443c BREAKING CHANGE: ret enum value as object (web-platform-tests#87) 8360040a9d chore(package): bump version number fa4b9a3ef1 BREAKING CHANGE: Use ES2015 syntax (web-platform-tests#84) 4252cef22e chore(package): update deps d6b17d84a1 chore(package): bump version number 174e47ea6d Check duplicated names (web-platform-tests#80) 981743ad2e remove legacycaller (web-platform-tests#79) 99100d174b Add "sequence" property to IDL Type AST definition (web-platform-tests#76) 23fc13f951 chore(CHANGELOG): regenerate 6b53eb357b chore(package): bump version dbce4340c7 feat: support TypeWithExtendedAttributes on generics (web-platform-tests#75) c5facac405 chore(CHANGELOG): regenerate 0077262a8f chore(CHANGELOG): regenerate bbbab23b3d BREAKING CHANGE: remove serializers (closes web-platform-tests#73) (web-platform-tests#74) 5d7a972728 docs(README): add namespaces (web-platform-tests#70) 1ad592c3bb chore(package): bump version 056f0cbaf8 chore(.travis): test for latest LTS/stable node versions (web-platform-tests#69) c6ef83e72f chore(pacakge): bump version f5d777c7ab fix extattr whitespace error (web-platform-tests#68) 112e8feb16 chore(package): bump version + update deps 8ec814b9f3 BREAKING CHANGE: deprecate arrays and exceptions (web-platform-tests#67) git-subtree-dir: resources/webidl2 git-subtree-split: 8a7ff70664ef54fbca77d9bda660865a369e9ce6
Closed
AutomatedTester
referenced
this pull request
in AutomatedTester/web-platform-tests
Dec 1, 2017
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 13, 2020
This implements PR #80 [1] and exposes userAgentData in workers. [1] WICG/ua-client-hints#80 Change-Id: I1de6067ab6c00855d7bf820e9646eb4e5a8c5fdb
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 13, 2020
This implements PR #80 [1] and exposes userAgentData in workers. [1] WICG/ua-client-hints#80 Change-Id: I1de6067ab6c00855d7bf820e9646eb4e5a8c5fdb
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 13, 2020
This implements PR #80 [1] and exposes userAgentData in workers. [1] WICG/ua-client-hints#80 Change-Id: I1de6067ab6c00855d7bf820e9646eb4e5a8c5fdb
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 16, 2020
This implements PR #80 [1] and exposes userAgentData in workers. [1] WICG/ua-client-hints#80 Change-Id: I1de6067ab6c00855d7bf820e9646eb4e5a8c5fdb
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 16, 2020
This implements PR #80 [1] and exposes userAgentData in workers. [1] WICG/ua-client-hints#80 Change-Id: I1de6067ab6c00855d7bf820e9646eb4e5a8c5fdb
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 16, 2020
This implements PR #80 [1] and exposes userAgentData in workers. [1] WICG/ua-client-hints#80 Change-Id: I1de6067ab6c00855d7bf820e9646eb4e5a8c5fdb
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 16, 2020
This implements PR #80 [1] and exposes userAgentData in workers. [1] WICG/ua-client-hints#80 Change-Id: I1de6067ab6c00855d7bf820e9646eb4e5a8c5fdb
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 16, 2020
This implements PR #80 [1] and exposes userAgentData in workers. [1] WICG/ua-client-hints#80 Change-Id: I1de6067ab6c00855d7bf820e9646eb4e5a8c5fdb
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 17, 2020
This implements PR #80 [1] and exposes userAgentData in workers. [1] WICG/ua-client-hints#80 Change-Id: I1de6067ab6c00855d7bf820e9646eb4e5a8c5fdb Bug: 1062192
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 17, 2020
This implements PR #80 [1] and exposes userAgentData in workers. [1] WICG/ua-client-hints#80 Change-Id: I1de6067ab6c00855d7bf820e9646eb4e5a8c5fdb Bug: 1062192 Change-Id: I1de6067ab6c00855d7bf820e9646eb4e5a8c5fdb
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 17, 2020
This implements PR #80 [1] and exposes userAgentData in workers. [1] WICG/ua-client-hints#80 Change-Id: I1de6067ab6c00855d7bf820e9646eb4e5a8c5fdb Bug: 1062192 Change-Id: I1de6067ab6c00855d7bf820e9646eb4e5a8c5fdb
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 18, 2020
This implements PR #80 [1] and exposes userAgentData in workers. [1] WICG/ua-client-hints#80 Bug: 1062192 Change-Id: I1de6067ab6c00855d7bf820e9646eb4e5a8c5fdb
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 18, 2020
This implements PR #80 [1] and exposes userAgentData in workers. [1] WICG/ua-client-hints#80 Bug: 1062192 Change-Id: I1de6067ab6c00855d7bf820e9646eb4e5a8c5fdb
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 18, 2020
This implements PR #80 [1] and exposes userAgentData in workers. [1] WICG/ua-client-hints#80 Bug: 1062192 Change-Id: I1de6067ab6c00855d7bf820e9646eb4e5a8c5fdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093220 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#751295}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 18, 2020
This implements PR #80 [1] and exposes userAgentData in workers. [1] WICG/ua-client-hints#80 Bug: 1062192 Change-Id: I1de6067ab6c00855d7bf820e9646eb4e5a8c5fdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093220 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#751295}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushed changes
Updated the tests with the recommended changes
Added test file for htmlallcollections