Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the flakiness in workers/worker-performance.worker.js #8711

Merged
merged 1 commit into from
Jan 7, 2018
Merged

Fix the flakiness in workers/worker-performance.worker.js #8711

merged 1 commit into from
Jan 7, 2018

Conversation

rniwa
Copy link
Contributor

@rniwa rniwa commented Dec 17, 2017 •
edited by wpt-pr-bot
Loading

This test was relying that performance.now() value changes from the time start was computed to when the first mark entry was created. Explicitly wait for performance.now() value to change instead to make the test more reliable.

@rniwa
Fix the flakiness in workers/worker-performance.worker.js
10d0758 
This test was relying that performance.now() value changes from the time start was computed to when the first mark entry was created. Explicitly wait for performance.now() value to change instead to make the test more reliable.
@w3c-bots
Copy link

w3c-bots commented Dec 17, 2017 •
edited
Loading

Build PASSED

Started: 2017-12-17 00:18:23
Finished: 2017-12-17 00:27:51

View more information about this build on:

@annevk annevk merged commit dab9c45 into web-platform-tests:master Jan 7, 2018
@annevk
Copy link
Member

annevk commented Jan 7, 2018

@igrigorik you might want to do a post-commit review. I guess you're not an OWNER for this.

@igrigorik
Copy link
Member

Looks good. /cc @tdresser

hubot pushed a commit to WebKit/WebKit-http that referenced this pull request Jan 8, 2018
Reduce the precision of "high" resolution time to 1ms
8985cd9 
https://bugs.webkit.org/show_bug.cgi?id=180910
<rdar://problem/36085943>

Reviewed by Saam Barati.

Source/WebCore:

Reduced the high prevision time's resolution to 1ms, the same precision as Date.now().

Also fixed the bug in fillRTCStats that we weren't reducing the time resolution in RTCStats dictionaries.

* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::fillRTCStats):
* page/Performance.cpp:
(WebCore::Performance::reduceTimeResolution):

LayoutTests:

Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711

* TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@226495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
bertogg pushed a commit to Igalia/webkit that referenced this pull request Jan 10, 2018
Merge r226495 - Reduce the precision of "high" resolution time to 1ms
7bbc954 
https://bugs.webkit.org/show_bug.cgi?id=180910
<rdar://problem/36085943>

Reviewed by Saam Barati.

Source/WebCore:

Reduced the high prevision time's resolution to 1ms, the same precision as Date.now().

Also fixed the bug in fillRTCStats that we weren't reducing the time resolution in RTCStats dictionaries.

* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::fillRTCStats):
* page/Performance.cpp:
(WebCore::Performance::reduceTimeResolution):

LayoutTests:

Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711

* TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/releases/WebKitGTK/webkit-2.18@226699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
zdobersek pushed a commit to WebPlatformForEmbedded/WPEWebKit that referenced this pull request Jul 18, 2018
@zdobersek
Reduce the precision of "high" resolution time to 1ms
d0a31ac 
https://bugs.webkit.org/show_bug.cgi?id=180910
<rdar://problem/36085943>

Reviewed by Saam Barati.

Source/WebCore:

Reduced the high prevision time's resolution to 1ms, the same precision as Date.now().

Also fixed the bug in fillRTCStats that we weren't reducing the time resolution in RTCStats dictionaries.

* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::fillRTCStats):
* page/Performance.cpp:
(WebCore::Performance::reduceTimeResolution):

LayoutTests:

Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711

* TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@226495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ashkulz pushed a commit to qtwebkit/webkit-mirror that referenced this pull request Jul 1, 2019
Apply patch. rdar://problem/36113340
4e5035f 
    Reduce the precision of "high" resolution time to 1ms
    https://bugs.webkit.org/show_bug.cgi?id=180910
    <rdar://problem/36085943>

    Reviewed by Saam Barati.

    Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
    due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711

    * TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/branches/safari-604.4.7.0-branch@226545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ashkulz pushed a commit to qtwebkit/webkit-mirror that referenced this pull request Jul 1, 2019
Apply patch. rdar://problem/36116741
f501149 
    Reduce the precision of "high" resolution time to 1ms
    https://bugs.webkit.org/show_bug.cgi?id=180910
    <rdar://problem/36085943>

    Reviewed by Saam Barati.

    Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
    due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711

    * TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/branches/safari-604.4.7.10-branch@226571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ashkulz pushed a commit to qtwebkit/webkit-mirror that referenced this pull request Jul 1, 2019
Apply patch. rdar://problem/36116546
6a946f8 
    Reduce the precision of "high" resolution time to 1ms
    https://bugs.webkit.org/show_bug.cgi?id=180910
    <rdar://problem/36085943>

    Reviewed by Saam Barati.

    Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
    due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711

    * TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/branches/safari-604.4.7.1-branch@226559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ashkulz pushed a commit to qtwebkit/webkit-mirror that referenced this pull request Jul 1, 2019
Apply patch. rdar://problem/36257610
4275ca6 
    Reduce the precision of "high" resolution time to 1ms
    https://bugs.webkit.org/show_bug.cgi?id=180910
    <rdar://problem/36085943>

    Reviewed by Saam Barati.

    Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
    due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711

    * TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/branches/safari-604.5.100-branch@226590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ashkulz pushed a commit to qtwebkit/webkit-mirror that referenced this pull request Jul 1, 2019
Apply patch. rdar://problem/36257607
95956d7 
    Reduce the precision of "high" resolution time to 1ms
    https://bugs.webkit.org/show_bug.cgi?id=180910
    <rdar://problem/36085943>

    Reviewed by Saam Barati.

    Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
    due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711

    * TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/branches/safari-604-branch@226584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ryanhaddad pushed a commit to WebKit/WebKit that referenced this pull request Dec 22, 2020
@rniwa
Reduce the precision of "high" resolution time to 1ms
25e5753 
https://bugs.webkit.org/show_bug.cgi?id=180910
<rdar://problem/36085943>

Reviewed by Saam Barati.

Source/WebCore:

Reduced the high prevision time's resolution to 1ms, the same precision as Date.now().

Also fixed the bug in fillRTCStats that we weren't reducing the time resolution in RTCStats dictionaries.

* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::fillRTCStats):
* page/Performance.cpp:
(WebCore::Performance::reduceTimeResolution):

LayoutTests:

Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711

* TestExpectations:


Canonical link: https://commits.webkit.org/197211@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@226495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JonWBedard pushed a commit to WebKit/WebKit that referenced this pull request Feb 3, 2021
@jasmarc
Apply patch. rdar://problem/36257607
054b530 
    Reduce the precision of "high" resolution time to 1ms
    https://bugs.webkit.org/show_bug.cgi?id=180910
    <rdar://problem/36085943>

    Reviewed by Saam Barati.

    Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
    due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711

    * TestExpectations:

Canonical link: https://commits.webkit.org/191388.305@safari-604-branch
git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-604-branch@226584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JonWBedard pushed a commit to WebKit/WebKit that referenced this pull request Feb 3, 2021
Apply patch. rdar://problem/36257607
397f87d 
    Reduce the precision of "high" resolution time to 1ms
    https://bugs.webkit.org/show_bug.cgi?id=180910
    <rdar://problem/36085943>

    Reviewed by Saam Barati.

    Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
    due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711

    * TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-604-branch@226584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JonWBedard pushed a commit to WebKit/WebKit that referenced this pull request Feb 3, 2021
@jasmarc
Apply patch. rdar://problem/36116741
9b134ff 
    Reduce the precision of "high" resolution time to 1ms
    https://bugs.webkit.org/show_bug.cgi?id=180910
    <rdar://problem/36085943>

    Reviewed by Saam Barati.

    Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
    due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711

    * TestExpectations:

Canonical link: https://commits.webkit.org/191388.294@safari-604.4.7.10-branch
git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-604.4.7.10-branch@226571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JonWBedard pushed a commit to WebKit/WebKit that referenced this pull request Feb 3, 2021
@jasmarc
Apply patch. rdar://problem/36116546
3a8911b 
    Reduce the precision of "high" resolution time to 1ms
    https://bugs.webkit.org/show_bug.cgi?id=180910
    <rdar://problem/36085943>

    Reviewed by Saam Barati.

    Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
    due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711

    * TestExpectations:

Canonical link: https://commits.webkit.org/191388.296@safari-604.4.7.1-branch
git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-604.4.7.1-branch@226559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JonWBedard pushed a commit to WebKit/WebKit that referenced this pull request Feb 3, 2021
Apply patch. rdar://problem/36257610
b248607 
    Reduce the precision of "high" resolution time to 1ms
    https://bugs.webkit.org/show_bug.cgi?id=180910
    <rdar://problem/36085943>

    Reviewed by Saam Barati.

    Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
    due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711

    * TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-604.5.100-branch@226590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JonWBedard pushed a commit to WebKit/WebKit that referenced this pull request Feb 3, 2021
@jasmarc
Apply patch. rdar://problem/36113340
8847128 
    Reduce the precision of "high" resolution time to 1ms
    https://bugs.webkit.org/show_bug.cgi?id=180910
    <rdar://problem/36085943>

    Reviewed by Saam Barati.

    Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
    due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711

    * TestExpectations:

Canonical link: https://commits.webkit.org/191388.293@safari-604.4.7.0-branch
git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-604.4.7.0-branch@226545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JonWBedard pushed a commit to WebKit/WebKit that referenced this pull request Feb 10, 2021
@jasmarc
Apply patch. rdar://problem/36257610
84cd0a4 
    Reduce the precision of "high" resolution time to 1ms
    https://bugs.webkit.org/show_bug.cgi?id=180910
    <rdar://problem/36085943>

    Reviewed by Saam Barati.

    Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
    due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711

    * TestExpectations:

Canonical link: https://commits.webkit.org/191388.305@safari-604.5.100-branch
git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-604.5.100-branch@226590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JonWBedard pushed a commit to WebKit/WebKit that referenced this pull request Feb 10, 2021
@jasmarc
Apply patch. rdar://problem/36257607
2fc6a2a 
    Reduce the precision of "high" resolution time to 1ms
    https://bugs.webkit.org/show_bug.cgi?id=180910
    <rdar://problem/36085943>

    Reviewed by Saam Barati.

    Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
    due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711

    * TestExpectations:

Canonical link: https://commits.webkit.org/191388.305@safari-604-branch
git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-604-branch@226584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JonWBedard pushed a commit to WebKit/WebKit that referenced this pull request Apr 13, 2021
@jasmarc
Apply patch. rdar://problem/36257610
6d44eca 
    Reduce the precision of "high" resolution time to 1ms
    https://bugs.webkit.org/show_bug.cgi?id=180910
    <rdar://problem/36085943>

    Reviewed by Saam Barati.

    Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
    due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711

    * TestExpectations:

Canonical link: https://commits.webkit.org/191388.305@safari-604.5.100-branch
git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-604.5.100-branch@226590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JonWBedard pushed a commit to WebKit/WebKit that referenced this pull request Apr 13, 2021
@jasmarc
Apply patch. rdar://problem/36257607
2113e64 
    Reduce the precision of "high" resolution time to 1ms
    https://bugs.webkit.org/show_bug.cgi?id=180910
    <rdar://problem/36085943>

    Reviewed by Saam Barati.

    Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
    due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711

    * TestExpectations:

Canonical link: https://commits.webkit.org/191388.305@safari-604-branch
git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-604-branch@226584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
@rniwa rniwa deleted the fix-flakiness-in-worker-performance.worker branch August 2, 2022 17:26
JonWBedard pushed a commit to WebKit/WebKit that referenced this pull request Dec 1, 2022
@rniwa @carlosgcampos
Merge r226495 - Reduce the precision of "high" resolution time to 1ms
66e9a0d 
https://bugs.webkit.org/show_bug.cgi?id=180910
<rdar://problem/36085943>

Reviewed by Saam Barati.

Source/WebCore:

Reduced the high prevision time's resolution to 1ms, the same precision as Date.now().

Also fixed the bug in fillRTCStats that we weren't reducing the time resolution in RTCStats dictionaries.

* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::fillRTCStats):
* page/Performance.cpp:
(WebCore::Performance::reduceTimeResolution):

LayoutTests:

Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html
due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711

* TestExpectations:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

@caitp caitp Awaiting requested review from caitp

@chunywang chunywang Awaiting requested review from chunywang

@jdm jdm Awaiting requested review from jdm

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees
No one assigned
Labels
wg-webapps workers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rniwa @w3c-bots @annevk @igrigorik @wpt-pr-bot