-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the flakiness in workers/worker-performance.worker.js #8711
Merged
annevk
merged 1 commit into
web-platform-tests:master
from
rniwa:fix-flakiness-in-worker-performance.worker
Jan 7, 2018
Merged
Fix the flakiness in workers/worker-performance.worker.js #8711
annevk
merged 1 commit into
web-platform-tests:master
from
rniwa:fix-flakiness-in-worker-performance.worker
Jan 7, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was relying that performance.now() value changes from the time start was computed to when the first mark entry was created. Explicitly wait for performance.now() value to change instead to make the test more reliable.
Build PASSEDStarted: 2017-12-17 00:18:23 View more information about this build on: |
annevk
approved these changes
Jan 7, 2018
@igrigorik you might want to do a post-commit review. I guess you're not an OWNER for this. |
Looks good. /cc @tdresser |
hubot
pushed a commit
to WebKit/WebKit-http
that referenced
this pull request
Jan 8, 2018
https://bugs.webkit.org/show_bug.cgi?id=180910 <rdar://problem/36085943> Reviewed by Saam Barati. Source/WebCore: Reduced the high prevision time's resolution to 1ms, the same precision as Date.now(). Also fixed the bug in fillRTCStats that we weren't reducing the time resolution in RTCStats dictionaries. * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::fillRTCStats): * page/Performance.cpp: (WebCore::Performance::reduceTimeResolution): LayoutTests: Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711 * TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@226495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
bertogg
pushed a commit
to Igalia/webkit
that referenced
this pull request
Jan 10, 2018
https://bugs.webkit.org/show_bug.cgi?id=180910 <rdar://problem/36085943> Reviewed by Saam Barati. Source/WebCore: Reduced the high prevision time's resolution to 1ms, the same precision as Date.now(). Also fixed the bug in fillRTCStats that we weren't reducing the time resolution in RTCStats dictionaries. * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::fillRTCStats): * page/Performance.cpp: (WebCore::Performance::reduceTimeResolution): LayoutTests: Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711 * TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/releases/WebKitGTK/webkit-2.18@226699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
zdobersek
pushed a commit
to WebPlatformForEmbedded/WPEWebKit
that referenced
this pull request
Jul 18, 2018
https://bugs.webkit.org/show_bug.cgi?id=180910 <rdar://problem/36085943> Reviewed by Saam Barati. Source/WebCore: Reduced the high prevision time's resolution to 1ms, the same precision as Date.now(). Also fixed the bug in fillRTCStats that we weren't reducing the time resolution in RTCStats dictionaries. * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::fillRTCStats): * page/Performance.cpp: (WebCore::Performance::reduceTimeResolution): LayoutTests: Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711 * TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@226495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ashkulz
pushed a commit
to qtwebkit/webkit-mirror
that referenced
this pull request
Jul 1, 2019
Reduce the precision of "high" resolution time to 1ms https://bugs.webkit.org/show_bug.cgi?id=180910 <rdar://problem/36085943> Reviewed by Saam Barati. Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711 * TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/branches/safari-604.4.7.0-branch@226545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ashkulz
pushed a commit
to qtwebkit/webkit-mirror
that referenced
this pull request
Jul 1, 2019
Reduce the precision of "high" resolution time to 1ms https://bugs.webkit.org/show_bug.cgi?id=180910 <rdar://problem/36085943> Reviewed by Saam Barati. Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711 * TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/branches/safari-604.4.7.10-branch@226571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ashkulz
pushed a commit
to qtwebkit/webkit-mirror
that referenced
this pull request
Jul 1, 2019
Reduce the precision of "high" resolution time to 1ms https://bugs.webkit.org/show_bug.cgi?id=180910 <rdar://problem/36085943> Reviewed by Saam Barati. Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711 * TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/branches/safari-604.4.7.1-branch@226559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ashkulz
pushed a commit
to qtwebkit/webkit-mirror
that referenced
this pull request
Jul 1, 2019
Reduce the precision of "high" resolution time to 1ms https://bugs.webkit.org/show_bug.cgi?id=180910 <rdar://problem/36085943> Reviewed by Saam Barati. Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711 * TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/branches/safari-604.5.100-branch@226590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ashkulz
pushed a commit
to qtwebkit/webkit-mirror
that referenced
this pull request
Jul 1, 2019
Reduce the precision of "high" resolution time to 1ms https://bugs.webkit.org/show_bug.cgi?id=180910 <rdar://problem/36085943> Reviewed by Saam Barati. Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711 * TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/branches/safari-604-branch@226584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ryanhaddad
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Dec 22, 2020
https://bugs.webkit.org/show_bug.cgi?id=180910 <rdar://problem/36085943> Reviewed by Saam Barati. Source/WebCore: Reduced the high prevision time's resolution to 1ms, the same precision as Date.now(). Also fixed the bug in fillRTCStats that we weren't reducing the time resolution in RTCStats dictionaries. * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::fillRTCStats): * page/Performance.cpp: (WebCore::Performance::reduceTimeResolution): LayoutTests: Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711 * TestExpectations: Canonical link: https://commits.webkit.org/197211@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@226495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JonWBedard
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Feb 3, 2021
Reduce the precision of "high" resolution time to 1ms https://bugs.webkit.org/show_bug.cgi?id=180910 <rdar://problem/36085943> Reviewed by Saam Barati. Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711 * TestExpectations: Canonical link: https://commits.webkit.org/191388.305@safari-604-branch git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-604-branch@226584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JonWBedard
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Feb 3, 2021
Reduce the precision of "high" resolution time to 1ms https://bugs.webkit.org/show_bug.cgi?id=180910 <rdar://problem/36085943> Reviewed by Saam Barati. Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711 * TestExpectations: git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-604-branch@226584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JonWBedard
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Feb 3, 2021
Reduce the precision of "high" resolution time to 1ms https://bugs.webkit.org/show_bug.cgi?id=180910 <rdar://problem/36085943> Reviewed by Saam Barati. Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711 * TestExpectations: Canonical link: https://commits.webkit.org/191388.294@safari-604.4.7.10-branch git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-604.4.7.10-branch@226571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JonWBedard
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Feb 3, 2021
Reduce the precision of "high" resolution time to 1ms https://bugs.webkit.org/show_bug.cgi?id=180910 <rdar://problem/36085943> Reviewed by Saam Barati. Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711 * TestExpectations: Canonical link: https://commits.webkit.org/191388.296@safari-604.4.7.1-branch git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-604.4.7.1-branch@226559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JonWBedard
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Feb 3, 2021
Reduce the precision of "high" resolution time to 1ms https://bugs.webkit.org/show_bug.cgi?id=180910 <rdar://problem/36085943> Reviewed by Saam Barati. Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711 * TestExpectations: git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-604.5.100-branch@226590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JonWBedard
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Feb 3, 2021
Reduce the precision of "high" resolution time to 1ms https://bugs.webkit.org/show_bug.cgi?id=180910 <rdar://problem/36085943> Reviewed by Saam Barati. Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711 * TestExpectations: Canonical link: https://commits.webkit.org/191388.293@safari-604.4.7.0-branch git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-604.4.7.0-branch@226545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JonWBedard
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Feb 10, 2021
Reduce the precision of "high" resolution time to 1ms https://bugs.webkit.org/show_bug.cgi?id=180910 <rdar://problem/36085943> Reviewed by Saam Barati. Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711 * TestExpectations: Canonical link: https://commits.webkit.org/191388.305@safari-604.5.100-branch git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-604.5.100-branch@226590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JonWBedard
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Feb 10, 2021
Reduce the precision of "high" resolution time to 1ms https://bugs.webkit.org/show_bug.cgi?id=180910 <rdar://problem/36085943> Reviewed by Saam Barati. Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711 * TestExpectations: Canonical link: https://commits.webkit.org/191388.305@safari-604-branch git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-604-branch@226584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JonWBedard
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Apr 13, 2021
Reduce the precision of "high" resolution time to 1ms https://bugs.webkit.org/show_bug.cgi?id=180910 <rdar://problem/36085943> Reviewed by Saam Barati. Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711 * TestExpectations: Canonical link: https://commits.webkit.org/191388.305@safari-604.5.100-branch git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-604.5.100-branch@226590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JonWBedard
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Apr 13, 2021
Reduce the precision of "high" resolution time to 1ms https://bugs.webkit.org/show_bug.cgi?id=180910 <rdar://problem/36085943> Reviewed by Saam Barati. Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711 * TestExpectations: Canonical link: https://commits.webkit.org/191388.305@safari-604-branch git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-604-branch@226584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JonWBedard
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Dec 1, 2022
https://bugs.webkit.org/show_bug.cgi?id=180910 <rdar://problem/36085943> Reviewed by Saam Barati. Source/WebCore: Reduced the high prevision time's resolution to 1ms, the same precision as Date.now(). Also fixed the bug in fillRTCStats that we weren't reducing the time resolution in RTCStats dictionaries. * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::fillRTCStats): * page/Performance.cpp: (WebCore::Performance::reduceTimeResolution): LayoutTests: Add a flaky test expectation to imported/w3c/web-platform-tests/workers/worker-performance.worker.html due to a test bug. The test fix is tracked in web-platform-tests/wpt#8711 * TestExpectations:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was relying that performance.now() value changes from the time start was computed to when the first mark entry was created. Explicitly wait for performance.now() value to change instead to make the test more reliable.