Introduce assert_time_equals_literal and use it. #9165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This assertion is supposed to be used where the first argument has a tolerance but the second argument doesn't have such tolerance. Whereas assert_times_equal() is supposed to be used for the case both arguments have the same tolerance, actually it hasn't, it will be fixed in a subsequent patch in this patch series. MozReview-Commit-ID: FEDHilbX2rm Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1430654 [ci skip]
|
Code reviewed upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assertion is supposed to be used where the first argument has a tolerance
but the second argument doesn't have such tolerance. Whereas
assert_times_equal() is supposed to be used for the case both arguments have
the same tolerance, actually it hasn't, it will be fixed in a subsequent patch
in this patch series.
MozReview-Commit-ID: FEDHilbX2rm
Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1430654 [ci skip]
This change is