[custom-elements] Some fixes for "is" attribute behavior changes #9505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for whatwg/dom#566. - document.createElement() and createElementNS() don't add "is" content attribute. - cloneNode() should clone custom elements even if they have no "is" content attributes or have "is" content attribute inconsistent with "is value."
wpt-pr-bot
requested review from
alsemenov,
deepak-sa,
domenic,
dominiccooney,
hayatoito,
kojiishi,
rniwa,
sgrekhov,
snuggs and
TakayoshiKochi
domenic
approved these changes
Feb 14, 2018
Right. |
Build PASSEDStarted: 2018-02-14 00:12:10 Failing Jobs
View more information about this build on: |
domenic
added a commit
to whatwg/dom
that referenced
this pull request
Feb 14, 2018
Part of fixing whatwg/html#3402. This changes two things: * It fixes the cloning steps to consult the internal is value, instead of the is="" content attribute. * It removes the step from createElement()/createElementNS() that would insert an is="" attribute in the created element, as we've now decided that is="" is a way of communicating to the parser, and not a general-purpose indicator of customized built-in-ness. See also whatwg/html#3444 for the other half of the fix. Tests: web-platform-tests/wpt#9505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for whatwg/dom#566.
document.createElement() and createElementNS() don't add "is" content
attribute.
cloneNode() should clone custom elements even if they have no "is"
content attributes or have "is" content attribute inconsistent with
"is value."