[css-typed-om] Implement correct ordering for StylePropertyMaps. #9729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 1, 2018
Build PASSEDStarted: 2018-03-01 06:30:55 Failing Jobs
View more information about this build on: |
The correct ordering of properties depends on the type of style map: - Computed: css properties first, then vendor prefixed ones, then custom properties. Within each category, sort by code point. - Inline: same order as the CSSStyleDeclaration. - Declared: same order as the CSSRule. Spec: https://drafts.css-houdini.org/css-typed-om-1/#stylepropertymapreadonly Bug: 545318 Change-Id: I34fe8f0741bdcc2188926b37635672a4dda32625 Reviewed-on: https://chromium-review.googlesource.com/940381 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#540066}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-940381
branch
from
d77cd1d
to
ab00e9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct ordering of properties depends on the type of style map:
custom properties. Within each category, sort by code point.
Spec: https://drafts.css-houdini.org/css-typed-om-1/#stylepropertymapreadonly
Bug: 545318
Change-Id: I34fe8f0741bdcc2188926b37635672a4dda32625
Reviewed-on: https://chromium-review.googlesource.com/940381
Commit-Queue: Darren Shen shend@chromium.org
Reviewed-by: nainar nainar@chromium.org
Cr-Commit-Position: refs/heads/master@{#540066}