Clean up CSP list initialization. #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in #209, we haven't done a good job keeping these algorithms up to date. This patch cleans them up, and a subsequent patch will adjust HTML accordingly.
mikewest
added a commit
to whatwg/html
that referenced
this pull request
Apr 27, 2017
Following up on w3c/webappsec-csp#210, this patch simplifies the integration point between HTML and CSP, delegating the functionality entirely to the latter.
annevk
reviewed
Apr 27, 2017
| 2. If |document| has an <a>embedding document</a> (|embedding|), then add | ||
| |embedding| to |documents|. | ||
| 2. If |document| has an [=embedding document=] (|embedding|), then add |embedding| to | ||
| |ancestors|. |
| 2. Add each of |global|'s | ||
| <a lt="the worker's documents">document</a>s to |documents|. | ||
| 2. If |owner| is a {{Window}}, set |policies| to |owner|'s [=associated Document=]'s | ||
| [=Document/CSP list=]. |
There was a problem hiding this comment.
An environment settings object cannot be a Window object.
There was a problem hiding this comment.
Also, where is this invoked from? Can't you use the WorkerGlobalScope's owner set?
|
Going to defer to Anne on this one, especially given #211 (which makes it hard to tell what we really want to be doing here) and lack of diff-applied view that would make reviewing this not take up more time than I can spare right now. :( |
ghost
mentioned this pull request
|
Closing in favor of #358 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #209, we haven't done a good job keeping these algorithms
up to date. This patch cleans them up, and a subsequent patch will adjust
HTML accordingly.
Preview | Diff