Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of global object/document usage #333

Merged
merged 1 commit into from
Sep 18, 2018
Merged

Cleanup of global object/document usage #333

merged 1 commit into from
Sep 18, 2018

Conversation

andypaicu
Copy link
Collaborator

@andypaicu andypaicu commented Sep 17, 2018 •
edited by pr-preview bot
Loading

This is a follow up on #254
and it will solve #208

Preview | Diff

mikewest
mikewest approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@mikewest mikewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning this up.

@andypaicu andypaicu merged commit 46bc83c into w3c:master Sep 18, 2018
@andypaicu andypaicu deleted the document-and-global-object branch September 18, 2018 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikewest mikewest mikewest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andypaicu @mikewest