Use “hash-algorithm” name (not old CSP2 “hash-algo” name) #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sideshowbarker
changed the title
annevk
reviewed
Feb 18, 2021
index.src.html
Outdated
| @@ -3912,8 +3912,8 @@ <h5 algorithm id="script-pre-request"> | |||
|
|
|||
| 1. If |directive|'s <a for="directive">value</a> does not | |||
| contain a <a>source expression</a> whose | |||
| <a grammar>hash-algorithm</a> is a <a>case-sensitive</a> match | |||
| for |source|'s `hash-algo` component, and whose | |||
| <a grammar>hash-algorithm</a> is an <a>case-sensitive</a> match | |||
There was a problem hiding this comment.
Why would this be "an"?
Shouldn’t be — should be “a” (it ended up as “an” because I had initially also changed “case-sensitive” to “ASCII case-insensitive” in this patch — before ending up deciding to split that part out into a separate patch). Fixed now
sideshowbarker
force-pushed
the
sideshowbarker/hash-algorithm-production-name-fix
branch
from
3284a8a
to
89e8195
Compare
will do after |
annevk
approved these changes
Feb 18, 2021
sideshowbarker
changed the title
sideshowbarker
deleted the
sideshowbarker/hash-algorithm-production-name-fix
branch
|
LGTM2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #418
Preview | Diff