Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify what the hash in the unsafe-hashes example refers to #503

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Clarify what the hash in the unsafe-hashes example refers to #503

merged 1 commit into from
Jun 28, 2021

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Jun 26, 2021

Maybe it's just me, but I was confused about this on my first read through this example. I thought the hash was there as an example of how to stack this with other CSP directives and didn't realize that it was the hash of the contents of the attribute.

Of course, that's key to why unsafe-hashes is better than unsafe-inline :)

@fmarier fmarier requested a review from annevk June 26, 2021 22:53
@mikewest mikewest merged commit 68dd529 into main Jun 28, 2021
@mikewest
Copy link
Member

Thanks!

@mikewest mikewest deleted the fmarier-patch-1 branch June 28, 2021 07:56
github-actions bot added a commit that referenced this pull request Jun 28, 2021
@fmarier @github-actions
Clarify what the hash in the unsafe-hashes example refers to (#503)
8e9b0ad 
SHA: 68dd529
Reason: push, by @mikewest

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk Awaiting requested review from annevk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fmarier @mikewest