Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validation of CSS markup #569

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Fix validation of CSS markup #569

merged 1 commit into from
Oct 4, 2022

Conversation

antosart
Copy link
Member

@antosart antosart commented Oct 4, 2022

It looks like the W3C markup validation tooling does not like anymore literal unicode in CSS (example https://github.com/w3c/webappsec-csp/actions/runs/3161943169/jobs/5149960278). While we should fix the validator, this is a workaround to make the CSP spec validate anyway.

@antosart antosart merged commit 3e1a960 into w3c:main Oct 4, 2022
@antosart antosart mentioned this pull request Oct 4, 2022
Merged
github-actions bot added a commit that referenced this pull request Oct 4, 2022
@antosart @github-actions
Fix validation of CSS markup (#569)
f31ee4d 
SHA: 3e1a960
Reason: push, by @antosart

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@sideshowbarker
Copy link
Contributor

sideshowbarker commented Oct 4, 2022 •
edited
Loading

It looks like the W3C markup validation tooling does not like anymore literal unicode in CSS (example w3c/webappsec-csp/actions/runs/3161943169/jobs/5149960278). While we should fix the validator, this is a workaround to make the CSP spec validate anyway.

If that content: "🔓" was not causing the checker to report any failure previously but is now, then it’s an unintended regression that yeah, we really should fix. I’m not aware of any recent changes to the CSS-checking backend that would cause this. cc’ing @ylafon to see if he has any ideas.

@antosart
Copy link
Member Author

antosart commented Oct 4, 2022

Might it be related to this change? validator/validator@3eae393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antosart @sideshowbarker