Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the webidentity destination #567

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Add support for the webidentity destination #567

merged 1 commit into from
Oct 5, 2022

Conversation

cbiesinger
Copy link
Contributor

@cbiesinger cbiesinger mentioned this pull request Sep 30, 2022
Merged
3 tasks
@cbiesinger
Copy link
Contributor Author

I don't understand the failed check, can someone explain...?

@clelland
Copy link
Contributor

clelland commented Oct 1, 2022 

$ java -jar "/home/runner/work/_actions/w3c/spec-prod/v2/node_modules/vnu-jar/build/dist/vnu.jar" --also-check-css index.html
"file:/home/runner/work/webappsec-csp/webappsec-csp.w3c/index.html":19.323-19.323: error: CSS: “content”: Parse Error.

Yeah, that does not appear related to the PR at all. I'd suspect an upstream issue with the build tools; a re-run didn't change anything, so it doesn't appear to be a transient issue.

mikewest
mikewest approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@mikewest mikewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll land this once the Fetch PR lands.

@antosart
Copy link
Member

antosart commented Oct 4, 2022

The failed check should be fixed by #569.

annevk pushed a commit to whatwg/fetch that referenced this pull request Oct 4, 2022
@cbiesinger
Add "webidentity" destination for FedCM
30d462d 
CSP PR: w3c/webappsec-csp#567.

Tests: web-platform-tests/wpt#36230.
@cbiesinger
Copy link
Contributor Author

Thanks! Looks like the fetch PR has landed now.

@mikewest mikewest merged commit c8fc273 into w3c:main Oct 5, 2022
github-actions bot added a commit that referenced this pull request Oct 5, 2022
@cbiesinger @github-actions
Add support for the webidentity destination (#567)
69b9f45 
SHA: c8fc273
Reason: push, by @mikewest

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikewest mikewest mikewest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cbiesinger @clelland @antosart @mikewest