Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove required condition on the attributes fror SecurityPolicyViolationEventInit dict #645

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

SaeidEid
Copy link
Collaborator

@SaeidEid SaeidEid commented Feb 21, 2024

The dictionary SecurityPolicyViolationEventInit is optional in the constructor of SecurityPolicyViolationEvent. This change removes the required attributes from the properties of this dictionary and adds default values to them.

Tested in web-platform-tests/wpt#44672.

Fixes: #631

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 21, 2024
The dictionary SecurityPolicyViolationEventInit is optional in the constructor of SecurityPolicyViolationEvent. This CL removes the required attributes from the properties of this dictionary and adds default values.

The change in the spec: w3c/webappsec-csp#645

Bug: 325291983
Change-Id: I61e5527e7e8ccc2cd35e5022397ff42bf83ccd9e
@antosart antosart merged commit 7839638 into w3c:main Feb 21, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Feb 21, 2024
#645)

SHA: 7839638
Reason: push, by antosart

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 21, 2024
The dictionary SecurityPolicyViolationEventInit is optional in the constructor of SecurityPolicyViolationEvent. This CL removes the required attributes from the properties of this dictionary and adds default values.

The change in the spec: w3c/webappsec-csp#645

Bug: 325291983
Change-Id: I61e5527e7e8ccc2cd35e5022397ff42bf83ccd9e
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 22, 2024
The dictionary SecurityPolicyViolationEventInit is optional in the constructor of SecurityPolicyViolationEvent. This CL removes the required attributes from the properties of this dictionary and adds default values.

The change in the spec: w3c/webappsec-csp#645

Bug: 325291983
Change-Id: I61e5527e7e8ccc2cd35e5022397ff42bf83ccd9e
aarongable pushed a commit to chromium/chromium that referenced this pull request Feb 22, 2024
The dictionary SecurityPolicyViolationEventInit is optional in the constructor of SecurityPolicyViolationEvent. This CL removes the required attributes from the properties of this dictionary and adds default values.

The change in the spec: w3c/webappsec-csp#645

Bug: 325291983
Change-Id: I61e5527e7e8ccc2cd35e5022397ff42bf83ccd9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5296364
Reviewed-by: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Jonathan Hao <phao@chromium.org>
Commit-Queue: Saeid Eid <saeideid@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1263930}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 22, 2024
The dictionary SecurityPolicyViolationEventInit is optional in the constructor of SecurityPolicyViolationEvent. This CL removes the required attributes from the properties of this dictionary and adds default values.

The change in the spec: w3c/webappsec-csp#645

Bug: 325291983
Change-Id: I61e5527e7e8ccc2cd35e5022397ff42bf83ccd9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5296364
Reviewed-by: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Jonathan Hao <phao@chromium.org>
Commit-Queue: Saeid Eid <saeideid@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1263930}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 22, 2024
The dictionary SecurityPolicyViolationEventInit is optional in the constructor of SecurityPolicyViolationEvent. This CL removes the required attributes from the properties of this dictionary and adds default values.

The change in the spec: w3c/webappsec-csp#645

Bug: 325291983
Change-Id: I61e5527e7e8ccc2cd35e5022397ff42bf83ccd9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5296364
Reviewed-by: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Jonathan Hao <phao@chromium.org>
Commit-Queue: Saeid Eid <saeideid@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1263930}
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 23, 2024
The dictionary SecurityPolicyViolationEventInit is optional in the constructor of SecurityPolicyViolationEvent. This CL removes the required attributes from the properties of this dictionary and adds default values.

The change in the spec: w3c/webappsec-csp#645

Bug: 325291983
Change-Id: I61e5527e7e8ccc2cd35e5022397ff42bf83ccd9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5296364
Reviewed-by: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Jonathan Hao <phao@chromium.org>
Commit-Queue: Saeid Eid <saeideid@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1263930}
@SaeidEid SaeidEid deleted the violation-event branch February 26, 2024 08:05
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 28, 2024
…PolicyViolationEventInit, a=testonly

Automatic update from web-platform-tests
Remove required attributes from SecurityPolicyViolationEventInit

The dictionary SecurityPolicyViolationEventInit is optional in the constructor of SecurityPolicyViolationEvent. This CL removes the required attributes from the properties of this dictionary and adds default values.

The change in the spec: w3c/webappsec-csp#645

Bug: 325291983
Change-Id: I61e5527e7e8ccc2cd35e5022397ff42bf83ccd9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5296364
Reviewed-by: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Jonathan Hao <phao@chromium.org>
Commit-Queue: Saeid Eid <saeideid@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1263930}

--

wpt-commits: c333c3295d253747283111627a0b96a96dbf27ad
wpt-pr: 44672
ErichDonGubler pushed a commit to ErichDonGubler/firefox that referenced this pull request Feb 28, 2024
…PolicyViolationEventInit, a=testonly

Automatic update from web-platform-tests
Remove required attributes from SecurityPolicyViolationEventInit

The dictionary SecurityPolicyViolationEventInit is optional in the constructor of SecurityPolicyViolationEvent. This CL removes the required attributes from the properties of this dictionary and adds default values.

The change in the spec: w3c/webappsec-csp#645

Bug: 325291983
Change-Id: I61e5527e7e8ccc2cd35e5022397ff42bf83ccd9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5296364
Reviewed-by: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Jonathan Hao <phao@chromium.org>
Commit-Queue: Saeid Eid <saeideid@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1263930}

--

wpt-commits: c333c3295d253747283111627a0b96a96dbf27ad
wpt-pr: 44672
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Mar 1, 2024
…l,dom-core,peterv

Implements the changes from w3c/webappsec-csp#645

(This still does not include changing DOMString to USVString)

Differential Revision: https://phabricator.services.mozilla.com/D202918
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Mar 4, 2024
…l,dom-core,peterv

Implements the changes from w3c/webappsec-csp#645

(This still does not include changing DOMString to USVString)

Differential Revision: https://phabricator.services.mozilla.com/D202918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with SecurityPolicyViolationEvent constructor and optional init dict
2 participants