-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove required condition on the attributes fror SecurityPolicyViolationEventInit dict #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 21, 2024
The dictionary SecurityPolicyViolationEventInit is optional in the constructor of SecurityPolicyViolationEvent. This CL removes the required attributes from the properties of this dictionary and adds default values. The change in the spec: w3c/webappsec-csp#645 Bug: 325291983 Change-Id: I61e5527e7e8ccc2cd35e5022397ff42bf83ccd9e
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 21, 2024
The dictionary SecurityPolicyViolationEventInit is optional in the constructor of SecurityPolicyViolationEvent. This CL removes the required attributes from the properties of this dictionary and adds default values. The change in the spec: w3c/webappsec-csp#645 Bug: 325291983 Change-Id: I61e5527e7e8ccc2cd35e5022397ff42bf83ccd9e
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 22, 2024
The dictionary SecurityPolicyViolationEventInit is optional in the constructor of SecurityPolicyViolationEvent. This CL removes the required attributes from the properties of this dictionary and adds default values. The change in the spec: w3c/webappsec-csp#645 Bug: 325291983 Change-Id: I61e5527e7e8ccc2cd35e5022397ff42bf83ccd9e
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Feb 22, 2024
The dictionary SecurityPolicyViolationEventInit is optional in the constructor of SecurityPolicyViolationEvent. This CL removes the required attributes from the properties of this dictionary and adds default values. The change in the spec: w3c/webappsec-csp#645 Bug: 325291983 Change-Id: I61e5527e7e8ccc2cd35e5022397ff42bf83ccd9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5296364 Reviewed-by: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by: Jonathan Hao <phao@chromium.org> Commit-Queue: Saeid Eid <saeideid@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/main@{#1263930}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 22, 2024
The dictionary SecurityPolicyViolationEventInit is optional in the constructor of SecurityPolicyViolationEvent. This CL removes the required attributes from the properties of this dictionary and adds default values. The change in the spec: w3c/webappsec-csp#645 Bug: 325291983 Change-Id: I61e5527e7e8ccc2cd35e5022397ff42bf83ccd9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5296364 Reviewed-by: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by: Jonathan Hao <phao@chromium.org> Commit-Queue: Saeid Eid <saeideid@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/main@{#1263930}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 22, 2024
The dictionary SecurityPolicyViolationEventInit is optional in the constructor of SecurityPolicyViolationEvent. This CL removes the required attributes from the properties of this dictionary and adds default values. The change in the spec: w3c/webappsec-csp#645 Bug: 325291983 Change-Id: I61e5527e7e8ccc2cd35e5022397ff42bf83ccd9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5296364 Reviewed-by: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by: Jonathan Hao <phao@chromium.org> Commit-Queue: Saeid Eid <saeideid@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/main@{#1263930}
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 23, 2024
The dictionary SecurityPolicyViolationEventInit is optional in the constructor of SecurityPolicyViolationEvent. This CL removes the required attributes from the properties of this dictionary and adds default values. The change in the spec: w3c/webappsec-csp#645 Bug: 325291983 Change-Id: I61e5527e7e8ccc2cd35e5022397ff42bf83ccd9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5296364 Reviewed-by: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by: Jonathan Hao <phao@chromium.org> Commit-Queue: Saeid Eid <saeideid@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/main@{#1263930}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 28, 2024
…PolicyViolationEventInit, a=testonly Automatic update from web-platform-tests Remove required attributes from SecurityPolicyViolationEventInit The dictionary SecurityPolicyViolationEventInit is optional in the constructor of SecurityPolicyViolationEvent. This CL removes the required attributes from the properties of this dictionary and adds default values. The change in the spec: w3c/webappsec-csp#645 Bug: 325291983 Change-Id: I61e5527e7e8ccc2cd35e5022397ff42bf83ccd9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5296364 Reviewed-by: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by: Jonathan Hao <phao@chromium.org> Commit-Queue: Saeid Eid <saeideid@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/main@{#1263930} -- wpt-commits: c333c3295d253747283111627a0b96a96dbf27ad wpt-pr: 44672
ErichDonGubler
pushed a commit
to ErichDonGubler/firefox
that referenced
this pull request
Feb 28, 2024
…PolicyViolationEventInit, a=testonly Automatic update from web-platform-tests Remove required attributes from SecurityPolicyViolationEventInit The dictionary SecurityPolicyViolationEventInit is optional in the constructor of SecurityPolicyViolationEvent. This CL removes the required attributes from the properties of this dictionary and adds default values. The change in the spec: w3c/webappsec-csp#645 Bug: 325291983 Change-Id: I61e5527e7e8ccc2cd35e5022397ff42bf83ccd9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5296364 Reviewed-by: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by: Jonathan Hao <phao@chromium.org> Commit-Queue: Saeid Eid <saeideid@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/main@{#1263930} -- wpt-commits: c333c3295d253747283111627a0b96a96dbf27ad wpt-pr: 44672
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 1, 2024
…l,dom-core,peterv Implements the changes from w3c/webappsec-csp#645 (This still does not include changing DOMString to USVString) Differential Revision: https://phabricator.services.mozilla.com/D202918
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 4, 2024
…l,dom-core,peterv Implements the changes from w3c/webappsec-csp#645 (This still does not include changing DOMString to USVString) Differential Revision: https://phabricator.services.mozilla.com/D202918
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dictionary SecurityPolicyViolationEventInit is optional in the constructor of SecurityPolicyViolationEvent. This change removes the required attributes from the properties of this dictionary and adds default values to them.
Tested in web-platform-tests/wpt#44672.
Fixes: #631