Remove required attributes from SecurityPolicyViolationEventInit #44672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5296364
branch
3 times, most recently
from
fc595b0
to
809e456
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5296364
branch
2 times, most recently
from
6f42b8b
to
afa8ace
Compare
The dictionary SecurityPolicyViolationEventInit is optional in the constructor of SecurityPolicyViolationEvent. This CL removes the required attributes from the properties of this dictionary and adds default values. The change in the spec: w3c/webappsec-csp#645 Bug: 325291983 Change-Id: I61e5527e7e8ccc2cd35e5022397ff42bf83ccd9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5296364 Reviewed-by: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by: Jonathan Hao <phao@chromium.org> Commit-Queue: Saeid Eid <saeideid@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/main@{#1263930}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5296364
branch
from
afa8ace
to
d87f8cb
Compare
wpt-pr-bot
approved these changes
Feb 22, 2024
|
#44716 is the culprit for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dictionary SecurityPolicyViolationEventInit is optional in the constructor of SecurityPolicyViolationEvent. This CL removes the required attributes from the properties of this dictionary and adds default values.
The change in the spec: w3c/webappsec-csp#645
Bug: 325291983
Change-Id: I61e5527e7e8ccc2cd35e5022397ff42bf83ccd9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5296364
Reviewed-by: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Jonathan Hao <phao@chromium.org>
Commit-Queue: Saeid Eid <saeideid@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1263930}