Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<portal> should result in a "nested" navigation. #46

Closed
mikewest opened this issue Sep 24, 2019 · 1 comment
Closed

<portal> should result in a "nested" navigation. #46

mikewest opened this issue Sep 24, 2019 · 1 comment

Comments

@mikewest
Copy link
Member

This might be taken care of by the Sec-Fetch-Frame-Owner proposal in #45, but if we stick with nested-navigation, we should apply it to <portal> requests as well. The logic in step 4 of https://w3c.github.io/webappsec-fetch-metadata/#abstract-opdef-set-mode doesn't currently account for portal browsing contexts (which are not "nested").

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 24, 2019
Requests from `<portal>` elements currently send a `Sec-Fetch-Mode` of
`navigation`. They ought to send something more like
`nested-navigation`, which more accurately represents the request's
status vis-a-vis its requestor.

w3c/webappsec-fetch-metadata#46

Bug: 1005143
Change-Id: Ib7f434ddf90d2e15b4bf139ab77c778a090251f4
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 24, 2019
Requests from `<portal>` elements currently send a `Sec-Fetch-Mode` of
`navigation`. They ought to send something more like
`nested-navigation`, which more accurately represents the request's
status vis-a-vis its requestor.

w3c/webappsec-fetch-metadata#46

Bug: 1005143
Change-Id: Ib7f434ddf90d2e15b4bf139ab77c778a090251f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819297
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Auto-Submit: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699399}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 24, 2019
Requests from `<portal>` elements currently send a `Sec-Fetch-Mode` of
`navigation`. They ought to send something more like
`nested-navigation`, which more accurately represents the request's
status vis-a-vis its requestor.

w3c/webappsec-fetch-metadata#46

Bug: 1005143
Change-Id: Ib7f434ddf90d2e15b4bf139ab77c778a090251f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819297
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Auto-Submit: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699399}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Sep 26, 2019
…<portal>` requests., a=testonly

Automatic update from web-platform-tests
Correctly support `Sec-Fetch-Mode` for `<portal>` requests.

Requests from `<portal>` elements currently send a `Sec-Fetch-Mode` of
`navigation`. They ought to send something more like
`nested-navigation`, which more accurately represents the request's
status vis-a-vis its requestor.

w3c/webappsec-fetch-metadata#46

Bug: 1005143
Change-Id: Ib7f434ddf90d2e15b4bf139ab77c778a090251f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819297
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Auto-Submit: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699399}

--

wpt-commits: 3bff4fcbad687be221f6830969fe4f7086ce2cf8
wpt-pr: 19217
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Sep 27, 2019
…<portal>` requests., a=testonly

Automatic update from web-platform-tests
Correctly support `Sec-Fetch-Mode` for `<portal>` requests.

Requests from `<portal>` elements currently send a `Sec-Fetch-Mode` of
`navigation`. They ought to send something more like
`nested-navigation`, which more accurately represents the request's
status vis-a-vis its requestor.

w3c/webappsec-fetch-metadata#46

Bug: 1005143
Change-Id: Ib7f434ddf90d2e15b4bf139ab77c778a090251f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819297
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Auto-Submit: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699399}

--

wpt-commits: 3bff4fcbad687be221f6830969fe4f7086ce2cf8
wpt-pr: 19217
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 4, 2019
…<portal>` requests., a=testonly

Automatic update from web-platform-tests
Correctly support `Sec-Fetch-Mode` for `<portal>` requests.

Requests from `<portal>` elements currently send a `Sec-Fetch-Mode` of
`navigation`. They ought to send something more like
`nested-navigation`, which more accurately represents the request's
status vis-a-vis its requestor.

w3c/webappsec-fetch-metadata#46

Bug: 1005143
Change-Id: Ib7f434ddf90d2e15b4bf139ab77c778a090251f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819297
Reviewed-by: Lucas Gadani <lfgchromium.org>
Reviewed-by: Alex Moshchuk <alexmoschromium.org>
Commit-Queue: Alex Moshchuk <alexmoschromium.org>
Auto-Submit: Mike West <mkwstchromium.org>
Cr-Commit-Position: refs/heads/master{#699399}

--

wpt-commits: 3bff4fcbad687be221f6830969fe4f7086ce2cf8
wpt-pr: 19217

UltraBlame original commit: 0503bbe78048ab0ace87cd251457c5870fb13034
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 4, 2019
…<portal>` requests., a=testonly

Automatic update from web-platform-tests
Correctly support `Sec-Fetch-Mode` for `<portal>` requests.

Requests from `<portal>` elements currently send a `Sec-Fetch-Mode` of
`navigation`. They ought to send something more like
`nested-navigation`, which more accurately represents the request's
status vis-a-vis its requestor.

w3c/webappsec-fetch-metadata#46

Bug: 1005143
Change-Id: Ib7f434ddf90d2e15b4bf139ab77c778a090251f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819297
Reviewed-by: Lucas Gadani <lfgchromium.org>
Reviewed-by: Alex Moshchuk <alexmoschromium.org>
Commit-Queue: Alex Moshchuk <alexmoschromium.org>
Auto-Submit: Mike West <mkwstchromium.org>
Cr-Commit-Position: refs/heads/master{#699399}

--

wpt-commits: 3bff4fcbad687be221f6830969fe4f7086ce2cf8
wpt-pr: 19217

UltraBlame original commit: 0503bbe78048ab0ace87cd251457c5870fb13034
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 5, 2019
…<portal>` requests., a=testonly

Automatic update from web-platform-tests
Correctly support `Sec-Fetch-Mode` for `<portal>` requests.

Requests from `<portal>` elements currently send a `Sec-Fetch-Mode` of
`navigation`. They ought to send something more like
`nested-navigation`, which more accurately represents the request's
status vis-a-vis its requestor.

w3c/webappsec-fetch-metadata#46

Bug: 1005143
Change-Id: Ib7f434ddf90d2e15b4bf139ab77c778a090251f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819297
Reviewed-by: Lucas Gadani <lfgchromium.org>
Reviewed-by: Alex Moshchuk <alexmoschromium.org>
Commit-Queue: Alex Moshchuk <alexmoschromium.org>
Auto-Submit: Mike West <mkwstchromium.org>
Cr-Commit-Position: refs/heads/master{#699399}

--

wpt-commits: 3bff4fcbad687be221f6830969fe4f7086ce2cf8
wpt-pr: 19217

UltraBlame original commit: 0503bbe78048ab0ace87cd251457c5870fb13034
@mikewest
Copy link
Member Author

We did not stick with nested-navigation. Closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant