Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add experimental features join-ad-interest-group and run-ad-auction #438

Merged
merged 4 commits into from
Mar 22, 2023

Conversation

qingxinwu
Copy link
Contributor

@qingxinwu qingxinwu commented Nov 29, 2021

Features join-ad-interest-group and run-ad-auction are enabled by default for all frames. The default behavior will be changed to same-origin iframes only in near future, before third party cookie is deprecated.
There is a flag AdInterestGroupAPIRestrictedPolicyByDefault (--enable-features=AdInterestGroupAPIRestrictedPolicyByDefault) which will disable the two features for cross-origin iframes by default. Then cross-origin iframes need to specify an allow attribute on the iframe, e.g. <iframe src="some_page.html" allow="join-ad-interest-group"></iframe>, in order to access the features.

@qingxinwu qingxinwu marked this pull request as draft November 29, 2021 19:12
@qingxinwu qingxinwu marked this pull request as ready for review November 29, 2021 19:15
@mikewest
Copy link
Member

mikewest commented Nov 30, 2021

Would you be willing to put up a PR against https://github.com/w3c/webappsec-permissions-policy/blob/main/features.md listing these features and linking to documentation explaining their function?

(Edit: I am dumb. That's what this is. :) )

The explainer linked in this PR doesn't list either of these feature names. It would be ideal to update that document to define the feature, and its default allowlist (for example: https://wicg.github.io/idle-detection/#api-permissions-policy).

@mikewest
Copy link
Member

(Also, for IPR reasons, you'll need to link your GitHub account with a W3C account, and follow the (Google internal) instructions at go/github to get into the right GitHub group.)

@qingxinwu
Copy link
Contributor Author

The explainer is updated to mention the feature names. It also talks about the ideal default allowlist, but we think the allowlist details fit more in a spec (which is still in progress) than in the explainer. Please let me know if there's any question. Thanks!

@clelland
Copy link
Collaborator

clelland commented Dec 6, 2022

Hey @qingxinwu - would it makes sense at this point to link these features to the spec instead, now that the feature definition has been integrated there?

@clelland
Copy link
Collaborator

Ping @qingxinwu :)

Update features "join-ad-interest-group" and "run-ad-auction" link from explainer to spec.
@qingxinwu
Copy link
Contributor Author

Hey @qingxinwu - would it makes sense at this point to link these features to the spec instead, now that the feature definition has been integrated there?

Updated to link to the spec.
Not sure why I missed this comment, sorry about that.

@clelland clelland merged commit b363be8 into w3c:main Mar 22, 2023
@clelland
Copy link
Collaborator

Thanks!

github-actions bot added a commit that referenced this pull request Mar 22, 2023
…438)

SHA: b363be8
Reason: push, by clelland

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to clelland/feature-policy that referenced this pull request Apr 1, 2023
…3c#438)

SHA: b363be8
Reason: push, by clelland

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants