Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch integration is incorrect #59

Closed
jdm opened this issue Jul 15, 2016 · 1 comment
Closed

Fetch integration is incorrect #59

jdm opened this issue Jul 15, 2016 · 1 comment
Labels
blocks-pr

Comments

@jdm
Copy link

jdm commented Jul 15, 2016 •
edited
Loading

Http-redirect fetch no longer has a step 15, and doesn't directly invoke anything from this specification.
@estark37
Copy link
Collaborator

Hmm, thanks. I suppose that should be immediately before step 13. TBH I don't remember if we ever got Fetch updated to actually invoke this algorithm. I'll file an issue and a PR against Fetch for that in addition to fixing this section.

@estark37 estark37 mentioned this issue Jul 15, 2016
Closed
estark37 added a commit to estark37/fetch that referenced this issue Jul 15, 2016
@estark37
Call out to Referrer Policy to set policy on redirect
10603a6 
Before following a redirect, Fetch should call out to Referrer Policy to
update the referrer policy on the request, if necessary. (In particular,
this applies when the redirect response contains a Referrer-Policy
header.)

This integration is described in
https://w3c.github.io/webappsec-referrer-policy/#integration-with-fetch,
though it needs to be updated per
w3c/webappsec-referrer-policy#59.
@estark37 estark37 mentioned this issue Jul 15, 2016
Closed
estark37 added a commit to estark37/webappsec-referrer-policy that referenced this issue Jul 15, 2016
@estark37
Update Integration with Fetch section
85185ad 
The description of when a referrer policy is set on redirect referred to
a non-existent step in the HTTP-redirect fetch algorithm. The
corresponding Fetch change is in
whatwg/fetch#335.

The section about when "Determine request's referrer" is called was also
inaccurate.

Fixes w3c#59
estark37 added a commit to estark37/webappsec-referrer-policy that referenced this issue Jul 15, 2016
@estark37
Update Integration with Fetch section
ecce327 
The description of when a referrer policy is set on redirect referred to
a non-existent step in the HTTP-redirect fetch algorithm. The
corresponding Fetch change is in
whatwg/fetch#335.

The section about when "Determine request's referrer" is called was also
inaccurate.

Fixes w3c#59
annevk pushed a commit to whatwg/fetch that referenced this issue Jul 19, 2016
@estark37 @annevk
Call out to Referrer Policy to set policy on redirect
a8f1cd5 
Before following a redirect, Fetch should call out to Referrer Policy to
update the referrer policy on the request, if necessary. (In particular,
this applies when the redirect response contains a Referrer-Policy
header.)

This integration is described in
https://w3c.github.io/webappsec-referrer-policy/#integration-with-fetch,
though it needs to be updated per
w3c/webappsec-referrer-policy#59.

Fixes #334.

PR: #335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocks-pr
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdm @estark37