SRI: Fail open on ineligible #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metromoxie
force-pushed
the
sri-ineligible-should-fail-open
branch
from
269bb45
to
3a62289
Compare
|
Now that eligibility is down to just checking for CORS or same-origin, I think this makes sense. |
|
Okay, I'm going to merge, since @fmarier and @devd seem to agree. @mozfreddyb, feel free to jump in if you have a different perspective. |
metromoxie
added a commit
that referenced
this pull request
Jun 6, 2015
SRI: Fail open on ineligible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the discussion in #317, I believe that ineligible resources should fail open, not closed. More specifically, since a CORS failure because of a lack of CORS headers from the server will result in a network error (and thus SRI will never be activated), this has the practical effect that if a developer forgets to add the crossorigin attribute, the integrity should not be enforced. Thoughts @devd @mozfreddyb @fmarier?