Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace around < > in Web IDL is unusual #335

Closed
foolip opened this issue Jan 30, 2017 · 4 comments
Closed

Whitespace around < > in Web IDL is unusual #335

foolip opened this issue Jan 30, 2017 · 4 comments
Milestone

Comments

@foolip
Copy link
Member

foolip commented Jan 30, 2017

I've seen no other spec do this, and I found it not great for readability.

@equalsJeffH equalsJeffH added this to the WD-05 milestone Feb 1, 2017
@nadalin nadalin closed this as completed Feb 1, 2017
@nadalin nadalin reopened this Feb 1, 2017
@equalsJeffH
Copy link
Contributor

equalsJeffH commented Feb 2, 2017

what the submitter was getting at is that we write our two promises in the webauthn IDL like so...

interface WebAuthentication {
    Promise < ScopedCredentialInfo > makeCredential (...);
    Promise < WebAuthnAssertion > getAssertion (...);
};

and what they are simply suggesting is..

interface WebAuthentication {
    Promise<ScopedCredentialInfo> makeCredential (...);
    Promise<WebAuthnAssertion>    getAssertion (...);
};

..as done, e.g., here..

interface PushManager {
    Promise<PushSubscription>    subscribe (optional PushSubscriptionOptions options);
    Promise<PushSubscription?>   getSubscription ();
    Promise<PushPermissionState> permissionState (optional PushSubscriptionOptions options);
};

..and throughout..
https://www.w3.org/TR/service-workers/

..as well as other W3C specs. this is trivial we should do it.

@foolip
Copy link
Member Author

foolip commented Feb 2, 2017

Yes, @equalsJeffH has it right.

@zcorpan
Copy link
Member

zcorpan commented Feb 3, 2017

Maybe also omit the space before (

@jyasskin
Copy link
Member

If you use <xmp> instead of <pre>, you won't have to escape the <s. However, speced/bikeshed#933.

jyasskin added a commit to jyasskin/webauthn that referenced this issue Feb 14, 2017
jyasskin added a commit to jyasskin/webauthn that referenced this issue Feb 14, 2017
@leshi leshi closed this as completed in 233ff10 Feb 14, 2017
WebAuthnBot pushed a commit that referenced this issue Feb 14, 2017
… IDL parameterized types and operations. (#340)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants