Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safetynet attestation does not return byte array as a response. #563

Closed
Kieun opened this issue Sep 12, 2017 · 1 comment
Closed

Safetynet attestation does not return byte array as a response. #563

Kieun opened this issue Sep 12, 2017 · 1 comment

Comments

@Kieun
Copy link
Member

Kieun commented Sep 12, 2017

Section 7.5 describes Android Safetynet attestation statement format.
The "response" value is defined as a byte string (Major type2 ). However, Safetynet API returns String instead of byte array.
See following getJwsResult() method.
https://developers.google.com/android/reference/com/google/android/gms/safetynet/SafetyNetApi.AttestationResponse
So, we need to change response type from a byte string (Major type 2) to a text string (Major type 3).
@AngeloKai
Copy link
Contributor

@christiaanbrand can you please look at this issue?

christiaanbrand pushed a commit to christiaanbrand/webauthn that referenced this issue Sep 18, 2017
Clarify Safetynet attestation return value
6e45cc1 
Clarify the encoding of SafetyNet attestation as a UTF8 encoded string. Closes w3c#563
@christiaanbrand christiaanbrand mentioned this issue Sep 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AngeloKai @Kieun