Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Safetynet attestation return value #572

Merged
merged 2 commits into from Sep 28, 2017

Conversation

christiaanbrand
Copy link

@christiaanbrand christiaanbrand commented Sep 18, 2017

Clarify the encoding of SafetyNet attestation as a UTF8 encoded string. Closes #563


Preview | Diff

Clarify the encoding of SafetyNet attestation as a UTF8 encoded string. Closes w3c#563
@nadalin nadalin added this to the WD-07 milestone Sep 19, 2017
index.bs Outdated
@@ -2496,7 +2496,7 @@ and the identity of the calling application.
:: The version number of Google Play Services responsible for providing the SafetyNet API.

: response
:: The value returned by the above SafetyNet API. This value is a JWS [[RFC7515]] object (see
:: The UTF8 encoded result of the getJwsResult() call of the SafetyNet API. This value is a JWS [[RFC7515]] object (see
Copy link
Member

@jyasskin jyasskin Sep 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use [=UTF-8 encoded=] to link to https://encoding.spec.whatwg.org/#utf-8-encode.

Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@christiaanbrand christiaanbrand merged commit 6589a10 into w3c:master Sep 28, 2017
WebAuthnBot pushed a commit that referenced this pull request Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants