#createCredential alg: "if options.authenticatorSelection is present..." may be incorrect

[equalsJeffH]

The current step 18 of #createCredential alg says:

If options.authenticatorSelection is present, for each authenticator...

However, if options.authenticatorSelection is not present, we will not invoke any authenticators, which will likely make the user sad.

Given that we need to pass options.authenticatorSelection.requireResidentKey and options.authenticatorSelection.requireUserVerification to authenticatorMakeCredential(), perhaps we should make authenticatorSelection a required member of MakePublicKeyCredentialOptions ? (unless I'm misunderstanding things...?)

[emlun]

See the first commit in #687

[emlun]

I made a separate PR with just that first commit: #696

[emlun]

I support making options.authenticatorSelection required and default to {}. Then we can also get rid of the "If authenticatorSelection is present" branch, and the descriptions of requireResidentKey and requireUserVerification in authenticatorMakeCredential won't describe possibly undefined behaviour. I suppose it would technically be a breaking change to how credentials.create() is implemented, but it wouldn't at all affect observable behaviour or the API on either end.

[emlun]

The bikeshed issue appeared in bikeshed commit aa80a167c54650c1c8f2382945f3894ee5b80bb4.

[equalsJeffH]

thx @emlun, see speced/bikeshed#1139

[emlun]

Fixed by #696