-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #692 #696
Fix issue #692 #696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely an improvement.
Note: I'm not sure what the Travis build error is talking about.
pr-preview compiled it fine, so it's probably fine to merge. |
yeah, I figured that out in order to get PR #693 to build (see f728b91) -- basically, one cannot (presently) have comments in <pre> blocks. i spose we oughta submit a bikeshed issue if no one else has as yet. (done: speced/bikeshed#1139) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
review: #696 (review)), LGTM, thanks! |
@akshayku @AngeloKai @christiaanbrand Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@emlun once @christiaanbrand approves please merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
See #692
Preview | Diff